Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename cdash config file #1856

Closed
nlslatt opened this issue Jun 21, 2022 · 0 comments · Fixed by #1857 or #1858
Closed

Rename cdash config file #1856

nlslatt opened this issue Jun 21, 2022 · 0 comments · Fixed by #1857 or #1858
Assignees
@nlslatt
Labels
type: task

Comments

@nlslatt
Copy link
Collaborator

nlslatt commented Jun 21, 2022

What Needs to be Done?

Rename CTestConfiguration.ini to CTestConfig.cmake for the benefit of CDash reporting.

Is your feature request related to a problem? Please describe.

Describe potential solution outcome

Describe alternatives you've considered

Additional context
@nlslatt nlslatt self-assigned this Jun 21, 2022
nlslatt added a commit that referenced this issue Jun 21, 2022
@nlslatt
#1856: ci: rename cdash config file
fb37670
@nlslatt nlslatt mentioned this issue Jun 21, 2022
Merged
lifflander pushed a commit that referenced this issue Jun 22, 2022
@prwolfe @lifflander
#1856: CI: This adds a script to run the build and test using cmake
0b1690d 
I have not tested this as the compiler is failing
on a different .o file each run. I will set up the
changes needed in the vt-ci as well, but I don't
expect I will get it tested before leaving for vacation.
Note that use of a ctest script might  have been
a better pattern, but both are claimed to work in
the documentation.
@lifflander lifflander mentioned this issue Jun 22, 2022
Merged
nlslatt pushed a commit that referenced this issue Jul 8, 2022
@prwolfe @nlslatt
#1856: CI: This adds a script to run the build and test using cmake
eb4fc96 
I have not tested this as the compiler is failing
on a different .o file each run. I will set up the
changes needed in the vt-ci as well, but I don't
expect I will get it tested before leaving for vacation.
Note that use of a ctest script might  have been
a better pattern, but both are claimed to work in
the documentation.
nlslatt pushed a commit that referenced this issue Jul 8, 2022
@prwolfe @nlslatt
#1856: Move to ctest script
cc100e3 
Despite the documentation, the inclusion of ctest
calls in the cmake script was doing the build and
test, but not submitting anything to CDash. This moves
to a ctest script called using the -S flag. I am still
seeing test failures due to overloading, but it seems to
be caused by the test definitions itself. All the example
scripts use the macro add_test_for_example_vt which does
set the PROCESSORS property, but other tests use the add_test
macro directly and do not set the number of processors.
I found this by looking at the generated CTestTestfile.cmake
files.
nlslatt pushed a commit that referenced this issue Jul 8, 2022
@prwolfe @nlslatt
#1856: Add PROCESSORS property for gtest generated tests
ba87226 
Hopefully this will keep us from overloading the
nodes as badly as we currently are.
prwolfe added a commit that referenced this issue Jul 11, 2022
@prwolfe
#1856: Add gitlab job name to CDash display name
7d4b0a0
nlslatt pushed a commit that referenced this issue Jul 11, 2022
@prwolfe @nlslatt
#1856: Add gitlab job name to CDash display name
614754d
nlslatt added a commit that referenced this issue Jul 11, 2022
@nlslatt
Merge pull request #1858 from DARMA-tasking/1856-add-ctest-build-script
eb4f144 
#1856: This adds a script to run the build and test using cmake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nlslatt nlslatt

Labels
type: task
Projects
None yet
Milestone
No milestone
1 participant
@nlslatt