Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to default find_package behavior #1891

Closed
3 tasks
nmm0 opened this issue Aug 2, 2022 · 0 comments · Fixed by #2232
Closed
3 tasks

switch to default find_package behavior #1891

nmm0 opened this issue Aug 2, 2022 · 0 comments · Fixed by #2232
Assignees
@JacobDomagala
Labels
type: task

Comments

@nmm0
Copy link
Collaborator

nmm0 commented Aug 2, 2022

Our find_package_local behavior differs from default CMake behavior (especially now that it supports package_ROOT which we have some custom logic to support the behavior of.
What Needs to be Done?

  • Ensure that our cmake works with package_ROOT
  • Switch our scripts to use package_ROOT syntax
  • Switch find_package_local behavior to use cmake find_package behavior
@nmm0 nmm0 added the type: task label Aug 2, 2022
@nmm0 nmm0 mentioned this issue Nov 29, 2022
Open
JacobDomagala added a commit that referenced this issue Dec 28, 2023
@JacobDomagala
#1891: Initial work for package_ROOT working with load_local_package.…
bc35c06 
…cmake
JacobDomagala added a commit that referenced this issue Dec 28, 2023
@JacobDomagala
#1891: Initial work for package_ROOT working with load_local_package.…
48d7552 
…cmake
JacobDomagala added a commit that referenced this issue Dec 28, 2023
@JacobDomagala
#1891: Update find_package_local to work with package_ROOT
d7f8ae1
@JacobDomagala JacobDomagala mentioned this issue Dec 28, 2023
Merged
@JacobDomagala JacobDomagala linked a pull request Dec 28, 2023 that will close this issue
1891: Update find_package_local to work with package_ROOT #2232
Merged
JacobDomagala added a commit that referenced this issue Dec 28, 2023
@JacobDomagala
#1891: Update ci scrips and cmake config files
817a242
JacobDomagala added a commit that referenced this issue Dec 28, 2023
@JacobDomagala
#1891: Update ci scrips and cmake config files
88f50d7
JacobDomagala added a commit that referenced this issue Dec 28, 2023
@JacobDomagala
#1891: Update ci scrips and cmake config files
203a09a
JacobDomagala added a commit that referenced this issue Dec 28, 2023
@JacobDomagala
#1891: Update ci scrips and cmake config files
e2d29a0
JacobDomagala added a commit that referenced this issue Dec 28, 2023
@JacobDomagala
#1891: Update ci scrips and cmake config files
bb643a8
JacobDomagala added a commit that referenced this issue Jan 16, 2024
@JacobDomagala
#1891: Update find_package_local to work with package_ROOT
d7fe443
JacobDomagala added a commit that referenced this issue Jan 16, 2024
@JacobDomagala
#1891: Update ci scrips and cmake config files
11f71a6
JacobDomagala added a commit that referenced this issue Jan 23, 2024
@JacobDomagala
#1891: Update find_package_local to work with package_ROOT
fdcf471
JacobDomagala added a commit that referenced this issue Jan 23, 2024
@JacobDomagala
#1891: Update ci scrips and cmake config files
18548b2
JacobDomagala added a commit that referenced this issue Jan 30, 2024
@JacobDomagala
#1891: Update find_package_local to work with package_ROOT
d78c494
JacobDomagala added a commit that referenced this issue Jan 30, 2024
@JacobDomagala
#1891: Update ci scrips and cmake config files
0f6176a
JacobDomagala added a commit that referenced this issue Feb 20, 2024
@JacobDomagala
#1891: Update find_package_local to work with package_ROOT
0ce0475
JacobDomagala added a commit that referenced this issue Feb 20, 2024
@JacobDomagala
#1891: Update ci scrips and cmake config files
8229144
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@JacobDomagala @cwschilly
#1891: Update find_package_local to work with package_ROOT
136de2e
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@JacobDomagala @cwschilly
#1891: Update ci scrips and cmake config files
023edc8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JacobDomagala JacobDomagala

Labels
type: task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1891: Update find_package_local to work with package_ROOT DARMA-tasking/vt
2 participants
@nmm0 @JacobDomagala