Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TraceScopedEvent and TraceScopedNote should have deleted copy constructors and defined move constructors/assign #2019

Closed
nmm0 opened this issue Nov 21, 2022 · 0 comments · Fixed by #2020
Closed

TraceScopedEvent and TraceScopedNote should have deleted copy constructors and defined move constructors/assign #2019

nmm0 opened this issue Nov 21, 2022 · 0 comments · Fixed by #2020
Assignees
@nmm0
Labels
type: task

Comments

@nmm0
Copy link
Collaborator

nmm0 commented Nov 21, 2022

Currently, they only have a deleted copy assignment operator.
@nmm0 nmm0 self-assigned this Nov 21, 2022
nmm0 added a commit that referenced this issue Nov 21, 2022
@nmm0
#2019: trace: add rule of 5 special methods to TraceScopedEvent and T…
22d105f 
…raceScopedNote
@nmm0 nmm0 mentioned this issue Nov 21, 2022
Merged
@nmm0 nmm0 linked a pull request Nov 21, 2022 that will close this issue
#2019: add move constructor/assign to TraceScopedEvent and TraceScopedNote #2020
Merged
PhilMiller added a commit that referenced this issue Nov 28, 2022
@PhilMiller
Merge pull request #2020 from DARMA-tasking/2019-tracescopedevent-and…
f5722f5 
…-tracescopednote-should-have-deleted-copy-constructors-and-defined-move-constructorsassign

#2019: add move constructor/assign to TraceScopedEvent and TraceScopedNote
cz4rs pushed a commit that referenced this issue Dec 28, 2022
@nmm0 @cz4rs
#2019: trace: add rule of 5 special methods to TraceScopedEvent and T…
37f80b5 
…raceScopedNote
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nmm0 nmm0

Labels
type: task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2019: add move constructor/assign to TraceScopedEvent and TraceScopedNote DARMA-tasking/vt
1 participant
@nmm0