Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

listInsertHere with an empty list fails check #2096

Closed
nlslatt opened this issue Mar 1, 2023 · 0 comments · Fixed by #2105
Closed

listInsertHere with an empty list fails check #2096

nlslatt opened this issue Mar 1, 2023 · 0 comments · Fixed by #2105

Comments

@nlslatt
Copy link
Collaborator

nlslatt commented Mar 1, 2023

Describe the bug
The check below from src/vt/vrt/collection/param/construct_params.h is too strict:

    if (not dynamic_membership_) {
      vtAssert(
        has_bounds_ or
        (not has_bounds_ and bulk_inserts_.size() == 1) or
        (not has_bounds_ and
         (list_inserts_.size() > 0 or list_insert_here_.size() > 0)),
        "Must have valid bounds or exactly one bulk insert or use list insertion"
      );
    }

It fails when a rank has called listInsertHere() with an empty list. Set a flag when listInsertHere() is called and check that instead of list_insert_here_.size() > 0 in the above code block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant