Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection broadcast loses message data due to moves when promoted to CollectionMessage #2102

Closed
lifflander opened this issue Mar 13, 2023 · 0 comments · Fixed by #2108
Closed
Assignees

Comments

@lifflander
Copy link
Collaborator

lifflander commented Mar 13, 2023

Describe the bug
When a broadcast to a collection occurs using a normal vt::Message (not a collection message) and it is serialized, the message is de-allocated preemptively before all the collection elements on a rank receive it (after the first one does). Due to a template bug in proxy.broadcast it won't actually accept a vt::Message (it looks for a type in vt::Message that doesn't exist). So the only way to get it to fail is by using a callback that targets a collection as a broadcast.

To Reproduce
Steps to reproduce the behavior:

  1. Run examples/callback/callback.cc

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Platform (please complete the following information):

  • Supercomputer or desktop [e.g., Trinity, Sierra)
  • Compiler environment [e.g., clang-4.0, gcc8]
  • Libraries [e.g., mpich-2, openmpi)
  • Commit ID or release of VT [e.g., vt-1.0.0]

Additional context
Add any other context about the problem here.

@lifflander lifflander self-assigned this Mar 13, 2023
@PhilMiller PhilMiller changed the title Collection broadcast looses message data due to moves when promoted to CollectionMessage Collection broadcast loses message data due to moves when promoted to CollectionMessage Mar 13, 2023
@lifflander lifflander linked a pull request Mar 15, 2023 that will close this issue
lifflander added a commit that referenced this issue Mar 16, 2023
lifflander added a commit that referenced this issue Mar 21, 2023
lifflander added a commit that referenced this issue Mar 21, 2023
lifflander added a commit that referenced this issue Mar 21, 2023
cz4rs pushed a commit that referenced this issue Mar 27, 2023
cz4rs pushed a commit that referenced this issue Mar 27, 2023
cz4rs pushed a commit that referenced this issue Mar 30, 2023
cz4rs pushed a commit that referenced this issue Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant