Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explore use of profiles in docker compose #2121

Closed
thearusable opened this issue Mar 29, 2023 · 1 comment · Fixed by #2207
Closed

Explore use of profiles in docker compose #2121

thearusable opened this issue Mar 29, 2023 · 1 comment · Fixed by #2207
Assignees
@thearusable
Labels
type: task

Comments

@thearusable
Copy link
Contributor

For now we use HOST_COMPILER only for NVCC builds. So I think it would be good to take a look at profiles in docker compose: profiles documentation. We could specify which services are needed for which profile and then run the docker compose like this: docker compose --profile nvidia up

This way we could have a general ubuntu-cpp service which we currently have and a specialized version for nvidia profile. Cache names will contain HOST_COMPILER only for nvidia builds.
@thearusable thearusable self-assigned this Mar 29, 2023
@thearusable thearusable mentioned this issue Mar 29, 2023
Merged
thearusable added a commit that referenced this issue Apr 11, 2023
@thearusable
#2121: Add parameter for ubuntu version in gnu-docs image
4b02f5b
thearusable added a commit that referenced this issue Apr 11, 2023
@thearusable
#2121: Add docker compose profiles for each compiler
95b868e
@thearusable thearusable mentioned this issue Apr 11, 2023
Closed
thearusable added a commit that referenced this issue Apr 11, 2023
@thearusable
#2121: Add docker compose profiles for each compiler
d5738b1
thearusable added a commit that referenced this issue Apr 11, 2023
@thearusable
#2121: Add docker compose profiles for each compiler
29eef4b
@nmm0 nmm0 mentioned this issue Apr 11, 2023
Open
thearusable added a commit that referenced this issue Oct 24, 2023
@thearusable
#2121: Add parameter for ubuntu version in gnu-docs image
916a51e
thearusable added a commit that referenced this issue Oct 24, 2023
@thearusable
#2121: Add docker compose profiles for each compiler
e9a3964
thearusable added a commit that referenced this issue Oct 24, 2023
@thearusable
#2121: Fix docker-compose file after rebase
2bffb66
@thearusable
Copy link
Contributor Author

thearusable commented Oct 24, 2023 •
edited
Loading

Look's like docker profiles wouldn't be useful for us. From the PR which I created we could use the new named volumes definition which doesn't require to specify all compiler/system combinations.

I'll create a separate PR with those changes

thearusable added a commit that referenced this issue Oct 24, 2023
@thearusable
#2121: Generalize names of named volumes
9f9fecd
thearusable added a commit that referenced this issue Oct 24, 2023
@thearusable
#2121: Generalize names of named volumes
3e6a60e
@thearusable thearusable mentioned this issue Oct 24, 2023
Merged
thearusable added a commit that referenced this issue Oct 24, 2023
@thearusable
#2121: Specify driver for named volume
9477855
thearusable added a commit that referenced this issue Nov 7, 2023
@thearusable
#2121: Generalize names of named volumes
476d7c9
thearusable added a commit that referenced this issue Nov 7, 2023
@thearusable
#2121: Specify driver for named volume
76daefb
thearusable added a commit that referenced this issue Nov 7, 2023
@thearusable
#2121: Test
a168483
thearusable added a commit that referenced this issue Nov 7, 2023
@thearusable
#2121: Test
348c3c2
thearusable added a commit that referenced this issue Nov 8, 2023
@thearusable
#2121: Generalize names of named volumes
8a1207a
thearusable added a commit that referenced this issue Nov 8, 2023
@thearusable
#2121: Specify driver for named volume
8b3870a
thearusable added a commit that referenced this issue Nov 8, 2023
@thearusable
#2121: Test
74c0d0a
thearusable added a commit that referenced this issue Nov 8, 2023
@thearusable
#2121: Test
92ce4fa
thearusable added a commit that referenced this issue Nov 8, 2023
@thearusable
#2121: Test
286dcef
thearusable added a commit that referenced this issue Nov 10, 2023
@thearusable
#2121: Test local driver
77b28d4
thearusable added a commit that referenced this issue Nov 10, 2023
@thearusable
#2121: Test local driver
5938651
thearusable added a commit that referenced this issue Nov 13, 2023
@thearusable
#2121: Generalize names of named volumes
4cd6967
thearusable added a commit that referenced this issue Nov 13, 2023
@thearusable
#2121: Specify driver for named volume
7eba807
thearusable added a commit that referenced this issue Dec 8, 2023
@thearusable
#2121: Add volume name suffix to the cache path
9044e03
thearusable added a commit that referenced this issue Dec 8, 2023
@thearusable
#2121: Add volume identifier suffix to build_root
e585614
thearusable added a commit that referenced this issue Dec 8, 2023
@thearusable
#2121: Reorder cache variables in .env file
2810abf
thearusable added a commit that referenced this issue Dec 8, 2023
@thearusable
#2121: Simplify path deduction
de3b76d
thearusable added a commit that referenced this issue Dec 14, 2023
@thearusable
#2121: Generalize names of named volumes
e7af7c3
thearusable added a commit that referenced this issue Dec 14, 2023
@thearusable
#2121: Simplify configuration of volumes
96e0578
thearusable added a commit that referenced this issue Dec 14, 2023
@thearusable
#2121: Remove create directory job from CI
1e97bca
thearusable added a commit that referenced this issue Dec 14, 2023
@thearusable
#2121: Temporary enable all CI pipelines
936e68c
thearusable added a commit that referenced this issue Dec 14, 2023
@thearusable
#2121: Add volume name suffix to the cache path
9b834f7
thearusable added a commit that referenced this issue Dec 14, 2023
@thearusable
#2121: Add volume identifier suffix to build_root
abf25f9
thearusable added a commit that referenced this issue Dec 14, 2023
@thearusable
#2121: Reorder cache variables in .env file
925501c
thearusable added a commit that referenced this issue Dec 14, 2023
@thearusable
#2121: Simplify path deduction
c3cbe0d
thearusable added a commit that referenced this issue Dec 14, 2023
@thearusable
#2121: Update bash expansion in .env file
5df3153
thearusable added a commit that referenced this issue Dec 14, 2023
@thearusable
#2121: Use build_root variable instead of CACHE
9f34305
thearusable added a commit that referenced this issue Dec 14, 2023
@thearusable
#2121: Test
9ce6b49
thearusable added a commit that referenced this issue Dec 14, 2023
@thearusable
#2121: Test
efea619
thearusable added a commit that referenced this issue Dec 14, 2023
@thearusable
#2121: test
ebdc028
thearusable added a commit that referenced this issue Dec 14, 2023
@thearusable
#2121: Fix build_root path
f2f7e7b
thearusable added a commit that referenced this issue Dec 15, 2023
@thearusable
#2121: Add more debug logs to CI jobs
d529361
thearusable added a commit that referenced this issue Dec 18, 2023
@thearusable
#2121: Print docker compose config
ab73329
thearusable added a commit that referenced this issue Dec 19, 2023
@thearusable
#2121: Change cache variable
080a377
thearusable added a commit that referenced this issue Dec 19, 2023
@thearusable
#2121: Test variable propagation
fae34b9
thearusable added a commit that referenced this issue Dec 19, 2023
@thearusable
#2121: Use new variable for volume mounting point
6e2c798
thearusable added a commit that referenced this issue Dec 19, 2023
@thearusable
#2121: Add volume name to path on CI
8b478b5
thearusable added a commit that referenced this issue Dec 19, 2023
@thearusable
#2121: Use build_root variable instead of CACHE
c30bb4b
thearusable added a commit that referenced this issue Dec 19, 2023
@thearusable
#2121: Fix build_root path
08ceffc
thearusable added a commit that referenced this issue Dec 19, 2023
@thearusable
#2121: Remove temporary changes to enable CI on dev branch
d63bcd6
thearusable added a commit that referenced this issue Dec 20, 2023
@thearusable
#2121: Remove temporary changes to enable CI on feature branch
d5f562c
lifflander added a commit that referenced this issue Dec 20, 2023
@lifflander
Merge pull request #2207 from DARMA-tasking/2121-generalize-named-vol…
13b1920 
…umes

#2121: Generalize names of named volumes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thearusable thearusable

Labels
type: task
Projects
None yet
Milestone
No milestone
1 participant
@thearusable