Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sure that the LB Data JSON examples are always up to date in documentation #2291

Closed
cz4rs opened this issue May 22, 2024 · 0 comments · Fixed by #2305
Closed

make sure that the LB Data JSON examples are always up to date in documentation #2291

cz4rs opened this issue May 22, 2024 · 0 comments · Fixed by #2305
Assignees
@thearusable
Labels
type: task

Comments

@cz4rs
Copy link
Contributor

cz4rs commented May 22, 2024 •
edited by lifflander
Loading

A follow up to #2124 to avoid docs getting out of sync again. This should also help catching any accidental changes in the generated files.

What Needs to be Done?

  • add a reference LB Data JSON file
  • add a unit test / example that will generate LB Data JSON file and compare it with the reference
  • make sure that the example is checked with schema validator
  • embed the reference JSON file in vt/docs/node_lb_data.md
  • make sure the JSON Python validator stays up to date also by including the segment of code
thearusable added a commit that referenced this issue Jun 20, 2024
@thearusable
#2291: Add script for generating sample LBDatafile with lb_iter example
841a296
thearusable added a commit that referenced this issue Jun 20, 2024
@thearusable
#2291: Add sample LBDatafile
6144129
thearusable added a commit that referenced this issue Jun 20, 2024
@thearusable
#2291: Temporary disable unit tests
40d9c21
@thearusable thearusable mentioned this issue Jun 20, 2024
Merged
thearusable added a commit that referenced this issue Jun 20, 2024
@thearusable
#2291: Add script for comparing the generate LBDatafile with the refe…
fec2957 
…rence
thearusable added a commit that referenced this issue Jun 20, 2024
@thearusable
#2291: Temporary enable gcc-9 pipeline on draft PRs
61b5112
thearusable added a commit that referenced this issue Jun 20, 2024
@thearusable
#2291: Add script for comparing the generate LBDatafile with the refe…
8d4ecac 
…rence
thearusable added a commit that referenced this issue Jun 20, 2024
@thearusable
#2291: Temporary enable gcc-9 pipeline on draft PRs
0fea364
thearusable added a commit that referenced this issue Jun 24, 2024
@thearusable
#2291: Temporary enable gcc-9 pipeline on draft PR
68921cc
thearusable added a commit that referenced this issue Jun 24, 2024
@thearusable
#2291: Increase math_epsilon for comparing time field
c035437
thearusable added a commit that referenced this issue Jun 24, 2024
@thearusable
#2291: Generate smaller example LBDatafile
fa4af98
thearusable added a commit that referenced this issue Jun 25, 2024
@thearusable
#2291: Run schema validation also on LBDatafile example
7c68720
thearusable added a commit that referenced this issue Jun 25, 2024
@thearusable
#2291: Use subprocess.call instead of Popen to improve security
289b514
thearusable added a commit that referenced this issue Jun 25, 2024
@thearusable
#2291: Make testing logs more readable
a55bff2
thearusable added a commit that referenced this issue Jun 25, 2024
@thearusable
#2291: Use shortest possible LBDatafile example
8da76ec
thearusable added a commit that referenced this issue Jun 25, 2024
@thearusable
#2291: Extract LBDatafile schema to separate python file
6221608
thearusable added a commit that referenced this issue Jun 25, 2024
@thearusable
#2291: Include scripts directory in doxygen
5bb0e01
thearusable added a commit that referenced this issue Jun 25, 2024
@thearusable
#2291: Replace static code snippets with real files for LBDatafile ex…
4f4c462 
…ample and validation schema
thearusable added a commit that referenced this issue Jun 26, 2024
@thearusable
#2291: Fix possibility for false positive CI result when checking LBD…
3ca2222 
…atafiles
thearusable added a commit that referenced this issue Jun 27, 2024
@thearusable
#2291: Update LBDatafile example
eef10d2
thearusable added a commit that referenced this issue Jun 27, 2024
@thearusable
#2291: Add simple example to generate LBDatafile with communications …
4e81bf8 
…field populated
thearusable added a commit that referenced this issue Jun 27, 2024
@thearusable
#2291: Enable generation of LBDatafiles by all examples present in vt
6f543d4
thearusable added a commit that referenced this issue Jun 27, 2024
@thearusable
#2291: Update python script to use output of the lb_data_file_generat…
48db297 
…or example
thearusable added a commit that referenced this issue Jun 27, 2024
@thearusable
#2291: Add script for generating sample LBDatafile with lb_iter example
f97bf6c
thearusable added a commit that referenced this issue Jun 27, 2024
@thearusable
#2291: Add sample LBDatafile
a56b4ea
thearusable added a commit that referenced this issue Jun 27, 2024
@thearusable
#2291: Add script for comparing the generate LBDatafile with the refe…
7aa1359 
…rence
thearusable added a commit that referenced this issue Jun 27, 2024
@thearusable
#2291: Temporary enable gcc-9 pipeline on draft PR
61a8732
thearusable added a commit that referenced this issue Jun 27, 2024
@thearusable
#2291: Increase math_epsilon for comparing time field
56fd542
thearusable added a commit that referenced this issue Jul 12, 2024
@thearusable
#2291: Update pip3 in the docker image to be able to install newer pa…
a0ec659 
…ckages
thearusable added a commit that referenced this issue Jul 12, 2024
@thearusable
#2291: Update scripts for the output to be less noisy
df3886c
thearusable added a commit that referenced this issue Jul 12, 2024
@thearusable
#2291: Update printing in the python compare script
7684481
thearusable added a commit that referenced this issue Jul 12, 2024
@thearusable
#2291: Fix typo in test_vt cmake file
7eefe77
thearusable added a commit that referenced this issue Jul 12, 2024
@thearusable
#2291: Update name of the variable used to enable the tests of LBdata…
f52d668 
…files
lifflander added a commit that referenced this issue Jul 16, 2024
@lifflander
Merge pull request #2305 from DARMA-tasking/2291-make-lb-data-example…
f5476ba 
…s-always-up-to-date

#2291: Make LB data examples always up to date
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2291: Add script for generating sample LBDatafile with lb_iter example
37c7611
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2291: Add sample LBDatafile
54825ca
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2291: Add script for comparing the generate LBDatafile with the refe…
2220a40 
…rence
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2291: Increase math_epsilon for comparing time field
38f5137
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2291: Generate smaller example LBDatafile
9462f1a
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2291: Run schema validation also on LBDatafile example
a5fed7b
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2291: Use subprocess.call instead of Popen to improve security
a62d431
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2291: Make testing logs more readable
ec2b979
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2291: Use shortest possible LBDatafile example
2d99721
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2291: Extract LBDatafile schema to separate python file
4ecfb4b
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2291: Include scripts directory in doxygen
3d11695
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2291: Replace static code snippets with real files for LBDatafile ex…
b9da013 
…ample and validation schema
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2291: Fix possibility for false positive CI result when checking LBD…
fbf3c77 
…atafiles
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2291: Update LBDatafile example
2a7cfa1
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2291: Add simple example to generate LBDatafile with communications …
5748a4a 
…field populated
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2291: Enable generation of LBDatafiles by all examples present in vt
b1f5e20
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2291: Update python script to use output of the lb_data_file_generat…
6b65eff 
…or example
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2291: Update LBDatafile example
06796b0
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2291: Update pip3 in the docker image to be able to install newer pa…
1587853 
…ckages
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2291: Update scripts for the output to be less noisy
f16a037
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2291: Update printing in the python compare script
2c5ae0b
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2291: Fix typo in test_vt cmake file
8c23f5d
cwschilly pushed a commit that referenced this issue Sep 20, 2024
@thearusable @cwschilly
#2291: Update name of the variable used to enable the tests of LBdata…
8c8d562 
…files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thearusable thearusable

Labels
type: task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2291: Make LB data examples always up to date DARMA-tasking/vt
2 participants
@cz4rs @thearusable