Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake fails to configure when checkpoint is present in lib #2323

Closed
cz4rs opened this issue Jul 10, 2024 · 1 comment · Fixed by #2324
Closed

CMake fails to configure when checkpoint is present in lib #2323

cz4rs opened this issue Jul 10, 2024 · 1 comment · Fixed by #2324
Assignees

Comments

@cz4rs
Copy link
Contributor

cz4rs commented Jul 10, 2024

Describe the bug
CMake fails to configure when checkpoint is present in lib directory, but -Dmagistrate_ROOT is not provided:

[cmake] CMake Error at src/CMakeLists.txt:318 (install):
[cmake]   install TARGETS given target "checkpoint" which does not exist.

To Reproduce

cmake -DCMAKE_BUILD_TYPE:STRING=Debug -DCMAKE_INSTALL_PREFIX:STRING=/home/cz4rs/code/vt/build/install -DMPI_C_COMPILER:STRING=mpicc -DMPI_CXX_COMPILER:STRING=mpicxx -DCMAKE_C_COMPILER:FILEPATH=/usr/bin/clang -DCMAKE_CXX_COMPILER:FILEPATH=/usr/bin/clang++ -S/home/cz4rs/code/vt -B/home/cz4rs/code/vt/build -G Ninja

Expected behavior
Following change is enough to fix the issue on vt side:

diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index 39c3b57a6..5e75e31ca 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -316,7 +316,7 @@ export(
 
 if (EXISTS "${PROJECT_LIB_DIR}/checkpoint")
   install(
-    TARGETS                 checkpoint
+    TARGETS                 magistrate
     EXPORT                  ${VIRTUAL_TRANSPORT_LIBRARY}
   )
 endif()

That might not be enough if we want to have checkpoint target available here for backwards compatibility.

@cz4rs
Copy link
Contributor Author

cz4rs commented Jul 10, 2024

@JacobDomagala Can you please have a look?

lifflander added a commit that referenced this issue Jul 18, 2024
…gure-when-checkpoint-is-present-in-lib

#2323: Fix an issue with magistrate target when it's included as a vt's subdirectory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants