Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make reduce return PendingSend #702

Closed
nmm0 opened this issue Feb 19, 2020 · 1 comment · Fixed by #714
Closed

make reduce return PendingSend #702

nmm0 opened this issue Feb 19, 2020 · 1 comment · Fixed by #714
Assignees
@nmm0
Labels
type: task

Comments

@nmm0
Copy link
Collaborator

nmm0 commented Feb 19, 2020

What Needs to be Done?
Currently theCollective()->reduce returns the sequence for the reduce rather than a PendingSend. This should be refactored to return a PendingSend to enable chaining.

Is your feature request related to a problem? Please describe.
Currently chaining does not support reduces

Describe potential solution outcome
Ideally, a reduces should be chainable. If there is a need for getting the epoch from the reduce there should be another way of getting it.
@nmm0 nmm0 self-assigned this Feb 19, 2020
@lifflander lifflander mentioned this issue Feb 20, 2020
Closed
@nmm0
Copy link
Collaborator Author

nmm0 commented Feb 20, 2020

Make SequentialIDType id parameter to an in/out pointer defaulting to null:
SequentialIDType *id = nullptr

If it's nullptr, the user doesn't care about getting the sequential id back (and internally the seq id is seq_none)

If it's non-null and seq_none, then the user will get back the generated sequence id. If it's non-null and not seq_none, then that sequence id is used for the reduce operation

nmm0 added a commit that referenced this issue Feb 28, 2020
@nmm0
#702: PendingSend: add new action type for epoch actions. Create a ne…
58a164b 
…w constructor that allows construction with the new EpochActionType. Additionally move some messages that are not used externally to private to preserve class invariant. Move the definitions of some non-templated functions to the source file. Make the move constructor noexcept.
nmm0 added a commit that referenced this issue Feb 28, 2020
@nmm0
#702: reduce: make reduce a delayed call by returning PendingSend for…
7e8dc44 
… collective reduce, collections, and objgroups

This makes returning a sequentialID impossible. In order for collections to order properly, add a reduceImmediate public overload set that takes the same parameters as reduce but returns the sequential id instead of a PendingSend. This is used internally by the new reduce and collection reduceMsgExprImpl, but can be called by the user.
nmm0 added a commit that referenced this issue Mar 2, 2020
@nmm0
#702: reduce: remove outdated comment
61eaa4b
nmm0 added a commit that referenced this issue Mar 2, 2020
@nmm0
#702: PendingSend: fix release not cleaning up epoch_action_ so it is…
35c5168 
…n't repeated on destruction
nmm0 added a commit that referenced this issue Mar 2, 2020
@nmm0
#702: reduce: use getEpochContextMsg instead of envelopeGetEpoch with…
8546c2d 
… reduce PendingSend

getEpochContextMsg mimicks the behavior of how the epoch is determined with send, but since a send may not happen this has to be done up front
nmm0 added a commit that referenced this issue Mar 2, 2020
@nmm0
#702: PendingSend: fix epoch action PendingSends not consuming on the…
5da6a26 
… epoch
nmm0 added a commit that referenced this issue Mar 2, 2020
@nmm0
#702: tests: add chaining test that includes reduce to test_term_chai…
aa057bf 
…ning.cc
nmm0 added a commit that referenced this issue Apr 29, 2020
@nmm0
#702: PendingSend: add new action type for epoch actions. Create a ne…
03a83ea 
…w constructor that allows construction with the new EpochActionType. Additionally move some messages that are not used externally to private to preserve class invariant. Move the definitions of some non-templated functions to the source file. Make the move constructor noexcept.
nmm0 added a commit that referenced this issue Apr 29, 2020
@nmm0
#702: reduce: make reduce a delayed call by returning PendingSend for…
6e6a34d 
… collective reduce, collections, and objgroups

This makes returning a sequentialID impossible. In order for collections to order properly, add a reduceImmediate public overload set that takes the same parameters as reduce but returns the sequential id instead of a PendingSend. This is used internally by the new reduce and collection reduceMsgExprImpl, but can be called by the user.
nmm0 added a commit that referenced this issue Apr 29, 2020
@nmm0
#702: reduce: remove outdated comment
a58faff
nmm0 added a commit that referenced this issue Apr 29, 2020
@nmm0
#702: PendingSend: fix release not cleaning up epoch_action_ so it is…
98f23f0 
…n't repeated on destruction
nmm0 added a commit that referenced this issue Apr 29, 2020
@nmm0
#702: reduce: use getEpochContextMsg instead of envelopeGetEpoch with…
e81e4f8 
… reduce PendingSend

getEpochContextMsg mimicks the behavior of how the epoch is determined with send, but since a send may not happen this has to be done up front
nmm0 added a commit that referenced this issue Apr 29, 2020
@nmm0
#702: PendingSend: fix epoch action PendingSends not consuming on the…
3b9c140 
… epoch
nmm0 added a commit that referenced this issue Apr 29, 2020
@nmm0
#702: tests: add chaining test that includes reduce to test_term_chai…
ab34712 
…ning.cc
nmm0 added a commit that referenced this issue Apr 29, 2020
@nmm0
#702: PendingSend: reduce pushEpoch and popEpoch in PendingSend::rele…
d82dfd6 
…ase for epoch that was causing a crash
nmm0 added a commit that referenced this issue Apr 29, 2020
@nmm0
#702: dependent_send_chain: add ability to merge dependent send chain…
633d3de 
…s to have a PendingSend be dependent on two chain sets
nmm0 added a commit that referenced this issue Apr 29, 2020
@nmm0
#702: chainset: add merging step to chain set
24f0d39
nmm0 added a commit that referenced this issue May 21, 2020
@nmm0
#702: cmake: fix missing rdmahandle header in install
66c170c
nmm0 added a commit that referenced this issue Jul 15, 2020
@nmm0
#702: PendingSend: add new action type for epoch actions. Create a ne…
9571dba 
…w constructor that allows construction with the new EpochActionType. Additionally move some messages that are not used externally to private to preserve class invariant. Move the definitions of some non-templated functions to the source file. Make the move constructor noexcept.
nmm0 added a commit that referenced this issue Jul 15, 2020
@nmm0
#702: reduce: make reduce a delayed call by returning PendingSend for…
708deb7 
… collective reduce, collections, and objgroups

This makes returning a sequentialID impossible. In order for collections to order properly, add a reduceImmediate public overload set that takes the same parameters as reduce but returns the sequential id instead of a PendingSend. This is used internally by the new reduce and collection reduceMsgExprImpl, but can be called by the user.
nmm0 added a commit that referenced this issue Jul 15, 2020
@nmm0
#702: PendingSend: fix release not cleaning up epoch_action_ so it is…
81dc6a0 
…n't repeated on destruction
nmm0 added a commit that referenced this issue Jul 15, 2020
@nmm0
#702: PendingSend: fix epoch action PendingSends not consuming on the…
c89cba1 
… epoch
nmm0 added a commit that referenced this issue Jul 15, 2020
@nmm0
#702: tests: add chaining test that includes reduce to test_term_chai…
b273f6e 
…ning.cc
nmm0 added a commit that referenced this issue Jul 15, 2020
@nmm0
#702: PendingSend: reduce pushEpoch and popEpoch in PendingSend::rele…
26948f7 
…ase for epoch that was causing a crash
nmm0 added a commit that referenced this issue Jul 15, 2020
@nmm0
#702: dependent_send_chain: add ability to merge dependent send chain…
149859a 
…s to have a PendingSend be dependent on two chain sets
nmm0 added a commit that referenced this issue Jul 15, 2020
@nmm0
#702: chainset: add merging step to chain set
f555528
nmm0 added a commit that referenced this issue Aug 24, 2020
@nmm0
#702: CollectionChainSet: add test for merge chainsets
00ba708
nmm0 added a commit that referenced this issue Aug 24, 2020
@nmm0
#702: test_termination_chaining_collective: clean up test code
46104e6
nmm0 added a commit that referenced this issue Aug 24, 2020
@nmm0
#702: test_termination_chaining_collective: use runInEpochCollective …
1d6ab33 
…in test code
nmm0 added a commit that referenced this issue Aug 24, 2020
@nmm0
#702: test_termination_chaining_collective: remove leftover epoch cre…
a10af4b 
…ation
nmm0 added a commit that referenced this issue Aug 25, 2020
@nmm0
#702: PendingSend: add new action type for epoch actions. Create a ne…
6dca1da 
…w constructor that allows construction with the new EpochActionType. Additionally move some messages that are not used externally to private to preserve class invariant. Move the definitions of some non-templated functions to the source file. Make the move constructor noexcept.
nmm0 added a commit that referenced this issue Aug 25, 2020
@nmm0
#702: reduce: make reduce a delayed call by returning PendingSend for…
cc55905 
… collective reduce, collections, and objgroups

This makes returning a sequentialID impossible. In order for collections to order properly, add a reduceImmediate public overload set that takes the same parameters as reduce but returns the sequential id instead of a PendingSend. This is used internally by the new reduce and collection reduceMsgExprImpl, but can be called by the user.
nmm0 added a commit that referenced this issue Aug 25, 2020
@nmm0
#702: PendingSend: fix release not cleaning up epoch_action_ so it is…
94175f9 
…n't repeated on destruction
nmm0 added a commit that referenced this issue Aug 25, 2020
@nmm0
#702: PendingSend: fix epoch action PendingSends not consuming on the…
b40c54c 
… epoch
nmm0 added a commit that referenced this issue Aug 25, 2020
@nmm0
#702: tests: add chaining test that includes reduce to test_term_chai…
abdfda0 
…ning.cc
nmm0 added a commit that referenced this issue Aug 25, 2020
@nmm0
#702: PendingSend: reduce pushEpoch and popEpoch in PendingSend::rele…
1af7efb 
…ase for epoch that was causing a crash
nmm0 added a commit that referenced this issue Aug 25, 2020
@nmm0
#702: dependent_send_chain: add ability to merge dependent send chain…
860a41e 
…s to have a PendingSend be dependent on two chain sets
nmm0 added a commit that referenced this issue Aug 25, 2020
@nmm0
#702: chainset: add merging step to chain set
bcd9d9e
nmm0 added a commit that referenced this issue Aug 25, 2020
@nmm0
#702: cmake: fix missing rdmahandle header in install
15eef91
nmm0 added a commit that referenced this issue Aug 25, 2020
@nmm0
#702: rebase onto new ReduceStamp API
fd8a0e1
nmm0 added a commit that referenced this issue Aug 25, 2020
@nmm0
#702: add documentation to MergedClosure and mergeChainStep
71ff4f6
nmm0 added a commit that referenced this issue Aug 25, 2020
@nmm0
#702: CollectionChainSet: fix formatting and add assertion to mergeSt…
7f31685 
…epCollective that the index exists in both chain sets
nmm0 added a commit that referenced this issue Aug 25, 2020
@nmm0
#702: CollectionChainSet: add documentation for mergeStepCollective
29c3bd1
nmm0 added a commit that referenced this issue Aug 25, 2020
@nmm0
#702: CollectionChainset: fix typo in documentation for mergeStepColl…
c16f658 
…ective
nmm0 added a commit that referenced this issue Aug 25, 2020
@nmm0
#702: TestTermChaining: add check for single rank test. TODO: if unif…
3b449fa 
…orm bcast/send is added add extra checks for combining those in the chainset.
nmm0 added a commit that referenced this issue Aug 25, 2020
@nmm0
#702: TestTermChaining: use newer reduce API
f2313e7
nmm0 added a commit that referenced this issue Aug 25, 2020
@nmm0
#702: TestTermChaining: run collection_chain_set.h through clang-format
bd64230
nmm0 added a commit that referenced this issue Aug 25, 2020
@nmm0
#702: TestTermChaining: update collection_chain_set.h documentation t…
37afc4a 
…o reflect that the chain sets deal with indices, not necessarily all resident elements from the collection
nmm0 added a commit that referenced this issue Aug 25, 2020
@nmm0
#702: TestTermChaining: remove collection_chain_set.h dead code
fb31ca1
nmm0 added a commit that referenced this issue Aug 25, 2020
@nmm0
#702: TestTermChaining: ensure that the callback is executed on the s…
9cc2971 
…ame node as the root for the reduce
nmm0 added a commit that referenced this issue Aug 25, 2020
@nmm0
#702: CollectionChainSet: fix typos in documentation
dc89b4d
nmm0 added a commit that referenced this issue Aug 25, 2020
@nmm0
#702: CollectionChainSet: add test for merge chainsets
a6e53bb
nmm0 added a commit that referenced this issue Aug 25, 2020
@nmm0
#702: test_termination_chaining_collective: clean up test code
727bd06
nmm0 added a commit that referenced this issue Aug 25, 2020
@nmm0
#702: test_termination_chaining_collective: use runInEpochCollective …
600d0bb 
…in test code
nmm0 added a commit that referenced this issue Aug 25, 2020
@nmm0
#702: test_termination_chaining_collective: remove leftover epoch cre…
beea5ea 
…ation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nmm0 nmm0

Labels
type: task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

702 make reduce return pending send DARMA-tasking/vt
1 participant
@nmm0