Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record communication stats per-subphase #941

Closed
2 tasks
PhilMiller opened this issue Jul 22, 2020 · 2 comments · Fixed by #1081
Closed
2 tasks

Record communication stats per-subphase #941

PhilMiller opened this issue Jul 22, 2020 · 2 comments · Fixed by #1081
Assignees
Labels
intro A potentially good introductory issue for a new developer to address type: task

Comments

@PhilMiller
Copy link
Member

What Needs to be Done?

  • Extend the instrumentation of objects' communication loads to record them at subphase granularity
  • Update the CommOverhead load model to use this

Is your feature request related to a problem? Please describe.

Describe potential solution outcome

Describe alternatives you've considered

Additional context

@PhilMiller PhilMiller added the intro A potentially good introductory issue for a new developer to address label Jul 22, 2020
@lifflander
Copy link
Collaborator

@bradybray Can you work on this next? We added subphases to ElementStats and NodeStats, but the communication information that is recorded is not stored per subphase (only per phase). Expand communication to be assigned a subphase, depending on which one is active.

@bradybray
Copy link

bradybray commented Sep 20, 2020

@lifflander Ok; I think I found where I'll be making the changes. I'll start here.

CommMapType const&
ElementStats::getComm(PhaseType const& phase) {
comm_.resize(phase + 1);
auto const& phase_comm = comm_[phase];
vt_debug_print(
lb, node,
"ElementStats: getComm: comm size={}, phase={}\n",
phase_comm.size(), phase
);
return phase_comm;
}

bradybray pushed a commit that referenced this issue Sep 23, 2020
bradybray pushed a commit that referenced this issue Sep 23, 2020
bradybray pushed a commit that referenced this issue Sep 23, 2020
bradybray pushed a commit that referenced this issue Sep 23, 2020
bradybray pushed a commit that referenced this issue Sep 23, 2020
bradybray pushed a commit that referenced this issue Oct 7, 2020
bradybray pushed a commit that referenced this issue Oct 7, 2020
bradybray pushed a commit that referenced this issue Oct 7, 2020
bradybray pushed a commit that referenced this issue Oct 7, 2020
bradybray pushed a commit that referenced this issue Oct 7, 2020
bradybray pushed a commit that referenced this issue Oct 15, 2020
bradybray pushed a commit that referenced this issue Oct 15, 2020
bradybray pushed a commit that referenced this issue Oct 15, 2020
bradybray pushed a commit that referenced this issue Oct 15, 2020
bradybray pushed a commit that referenced this issue Oct 15, 2020
bradybray pushed a commit that referenced this issue Oct 15, 2020
bradybray pushed a commit that referenced this issue Oct 15, 2020
bradybray pushed a commit that referenced this issue Oct 15, 2020
PhilMiller added a commit that referenced this issue Oct 15, 2020
…stats-per-subphase

#941 added subphase support to loadComm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
intro A potentially good introductory issue for a new developer to address type: task
Projects
None yet
3 participants