-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1086 lb refactor #1087
1086 lb refactor #1087
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Failure of clang-8/macosx/mpich was seemingly due to #958 |
Codecov Report
@@ Coverage Diff @@
## develop #1087 +/- ##
===========================================
- Coverage 77.66% 77.65% -0.01%
===========================================
Files 672 671 -1
Lines 25806 25794 -12
===========================================
- Hits 20042 20031 -11
+ Misses 5764 5763 -1
|
Does this preempt #1059 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was curious about the usage of lb_instances_
here but i can see that in PR #1059 it makes more sense when you allow LBType::NoLB
to be a valid value
Fixes #1086