Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1098: Set default value of vt_ci_build to '0' inside CMake #1109

Merged
merged 1 commit into from
Oct 13, 2020
Merged

1098: Set default value of vt_ci_build to '0' inside CMake #1109

merged 1 commit into from
Oct 13, 2020

Conversation

JacobDomagala
Copy link
Contributor

Fixes #1098

@JacobDomagala JacobDomagala force-pushed the 1098-enable-assertions-during-ci branch from 25c3b5a to e66eab2 Compare October 13, 2020 16:18
@JacobDomagala JacobDomagala mentioned this pull request Oct 13, 2020
Merged
@codecov
Copy link

codecov bot commented Oct 13, 2020

Codecov Report

Merging #1109 into develop will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1109      +/-   ##
===========================================
+ Coverage    76.25%   76.28%   +0.03%     
===========================================
  Files          702      702              
  Lines        26540    26540              
===========================================
+ Hits         20238    20246       +8     
+ Misses        6302     6294       -8
Impacted Files Coverage Δ
tests/unit/atomic/test_atomic.cc 100.00% <0.00%> (+1.31%) ⬆️
src/vt/termination/dijkstra-scholten/comm.cc 67.27% <0.00%> (+12.72%) ⬆️

@JacobDomagala
Copy link
Contributor Author

Hotfix for discovered issue (#1107 (comment))

jstrzebonski
jstrzebonski approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@jstrzebonski jstrzebonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine.

@JacobDomagala JacobDomagala merged commit a1be253 into develop Oct 13, 2020
@lifflander lifflander mentioned this pull request Oct 13, 2020
Open
@cz4rs cz4rs mentioned this pull request Jun 15, 2021
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstrzebonski jstrzebonski jstrzebonski approved these changes

@PhilMiller PhilMiller PhilMiller approved these changes

@cz4rs cz4rs Awaiting requested review from cz4rs

@lifflander lifflander Awaiting requested review from lifflander

Assignees
No one assigned
Labels
1.0.0-beta.10.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable assertions during CI when release builds are used
4 participants
@JacobDomagala @PhilMiller @jstrzebonski @cz4rs