1201: Add -Werror for CI builds that are warning clean

CMakeLists.txt

@@ -101,6 +101,10 @@ option(vt_mimalloc_enabled "Build VT with mimalloc" OFF)
 option(vt_mimalloc_static "Build VT with mimalloc using static linking" ON)
 option(vt_asan_enabled "Build VT with address sanitizer" OFF)
 
+option(vt_werror_enabled "Build VT with -Werror enabled" OFF)
+if (vt_werror_enabled)
+  enable_cxx_compiler_flag_if_supported("-Werror")
+endif()
 include(cmake/load_bundled_libraries.cmake)
 
 # Primary VT build

ci/azure/azure-clang-3.9-ubuntu-mpich.yml

@@ -35,6 +35,7 @@ variables:
   VT_MIMALLOC: 0
   VT_DOCS: 0
   VT_ASAN: 0
+  VT_WERROR: 1
   VT_POOL: 1
   VT_EXTENDED_TESTS: 1
   VT_UNITY_BUILD: 1

ci/azure/azure-clang-5.0-ubuntu-mpich.yml

@@ -35,6 +35,7 @@ variables:
   VT_MIMALLOC: 0
   VT_DOCS: 0
   VT_ASAN: 0
+  VT_WERROR: 1
   VT_POOL: 1
   VT_EXTENDED_TESTS: 1
   VT_UNITY_BUILD: 1

ci/azure/azure-clang-8-alpine-mpich.yml

@@ -35,6 +35,7 @@ variables:
   VT_MIMALLOC: 0
   VT_DOCS: 0
   VT_ASAN: 0
+  VT_WERROR: 1
   VT_POOL: 1
   VT_EXTENDED_TESTS: 1
   VT_UNITY_BUILD: 1

ci/azure/azure-gcc-10-ubuntu-openmpi.yml

@@ -35,6 +35,7 @@ variables:
   VT_MIMALLOC: 0
   VT_DOCS: 0
   VT_ASAN: 0
+  VT_WERROR: 1
   VT_POOL: 1
   VT_EXTENDED_TESTS: 1
   VT_UNITY_BUILD: 1

ci/azure/azure-gcc-5-ubuntu-mpich.yml

@@ -35,6 +35,7 @@ variables:
   VT_MIMALLOC: 0
   VT_DOCS: 0
   VT_ASAN: 0
+  VT_WERROR: 0
   VT_POOL: 1
   VT_EXTENDED_TESTS: 1
   VT_UNITY_BUILD: 1

ci/azure/azure-gcc-6-ubuntu-mpich.yml

@@ -35,6 +35,7 @@ variables:
   VT_MIMALLOC: 0
   VT_DOCS: 0
   VT_ASAN: 0
+  VT_WERROR: 1
   VT_POOL: 1
   VT_EXTENDED_TESTS: 1
   VT_UNITY_BUILD: 1

ci/azure/azure-gcc-7-ubuntu-mpich.yml

@@ -35,6 +35,7 @@ variables:
   VT_MIMALLOC: 0
   VT_DOCS: 0
   VT_ASAN: 0
+  VT_WERROR: 1
   VT_POOL: 1
   VT_EXTENDED_TESTS: 1
   VT_UNITY_BUILD: 1

ci/azure/azure-gcc-8-ubuntu-mpich.yml

@@ -35,6 +35,7 @@ variables:
   VT_MIMALLOC: 0
   VT_DOCS: 0
   VT_ASAN: 1
+  VT_WERROR: 1
   VT_POOL: 0
   VT_EXTENDED_TESTS: 1
   VT_UNITY_BUILD: 1

ci/azure/azure-gcc-9-ubuntu-mpich.yml

@@ -35,6 +35,7 @@ variables:
   VT_MIMALLOC: 0
   VT_DOCS: 0
   VT_ASAN: 0
+  VT_WERROR: 1
   VT_POOL: 1
   VT_EXTENDED_TESTS: 1
   VT_UNITY_BUILD: 1

ci/azure/azure-intel-18-ubuntu-mpich-extended.yml

@@ -29,6 +29,7 @@ variables:
   VT_MIMALLOC: 0
   VT_DOCS: 0
   VT_ASAN: 0
+  VT_WERROR: 0
   VT_POOL: 0
   VT_EXTENDED_TESTS: 1
   VT_UNITY_BUILD: 1

ci/azure/azure-intel-18-ubuntu-mpich.yml

@@ -35,6 +35,7 @@ variables:
   VT_MIMALLOC: 0
   VT_DOCS: 0
   VT_ASAN: 0
+  VT_WERROR: 1
   VT_POOL: 0
   VT_EXTENDED_TESTS: 0
   VT_UNITY_BUILD: 1

ci/azure/azure-intel-19-ubuntu-mpich.yml

@@ -35,6 +35,7 @@ variables:
   VT_MIMALLOC: 0
   VT_DOCS: 0
   VT_ASAN: 0
+  VT_WERROR: 1
   VT_POOL: 0
   VT_EXTENDED_TESTS: 0
   VT_UNITY_BUILD: 1

ci/azure/azure-nvidia-10-ubuntu-mpich-extended.yml

@@ -29,6 +29,7 @@ variables:
   VT_MIMALLOC: 0
   VT_DOCS: 0
   VT_ASAN: 0
+  VT_WERROR: 0
   VT_POOL: 0
   VT_EXTENDED_TESTS: 1
   VT_UNITY_BUILD: 1

ci/azure/azure-nvidia-10-ubuntu-mpich.yml

@@ -35,6 +35,7 @@ variables:
   VT_MIMALLOC: 0
   VT_DOCS: 0
   VT_ASAN: 0
+  VT_WERROR: 0
   VT_POOL: 0
   VT_EXTENDED_TESTS: 0
   VT_UNITY_BUILD: 1

ci/azure/azure-nvidia-11-ubuntu-mpich-extended.yml

@@ -29,6 +29,7 @@ variables:
   VT_MIMALLOC: 0
   VT_DOCS: 0
   VT_ASAN: 0
+  VT_WERROR: 0
   VT_POOL: 0
   VT_EXTENDED_TESTS: 1
   VT_UNITY_BUILD: 1

ci/azure/azure-nvidia-11-ubuntu-mpich.yml

@@ -35,6 +35,7 @@ variables:
   VT_MIMALLOC: 0
   VT_DOCS: 0
   VT_ASAN: 0
+  VT_WERROR: 0
   VT_POOL: 0
   VT_EXTENDED_TESTS: 0
   VT_UNITY_BUILD: 1

ci/build_cpp.sh

@@ -102,6 +102,7 @@ cmake -G "${CMAKE_GENERATOR:-Ninja}" \
       -Dvt_doxygen_enabled="${VT_DOXYGEN_ENABLED:-0}" \
       -Dvt_mimalloc_enabled="${VT_MIMALLOC_ENABLED:-0}" \
       -Dvt_asan_enabled="${VT_ASAN_ENABLED:-0}" \
+      -Dvt_werror_enabled="${VT_WERROR_ENABLED:-0}" \
       -Dvt_pool_enabled="${VT_POOL_ENABLED:-1}" \
       -Dvt_build_extended_tests="${VT_EXTENDED_TESTS_ENABLED:-1}" \
       -Dvt_zoltan_enabled="${VT_ZOLTAN_ENABLED:-0}" \

ci/docker/alpine-cpp.dockerfile

@@ -27,6 +27,7 @@ ARG VT_TRACE_RUNTIME_ENABLED
 ARG VT_MIMALLOC_ENABLED
 ARG VT_DOXYGEN_ENABLED
 ARG VT_ASAN_ENABLED
+ARG VT_WERROR_ENABLED
 ARG VT_POOL_ENABLED
 ARG CMAKE_BUILD_TYPE
 
@@ -36,6 +37,7 @@ ENV VT_LB_ENABLED=${VT_LB_ENABLED} \
     VT_DOXYGEN_ENABLED=${VT_DOXYGEN_ENABLED} \
     VT_TRACE_RUNTIME_ENABLED=${VT_TRACE_RUNTIME} \
     VT_ASAN_ENABLED=${VT_ASAN_ENABLED} \
+    VT_WERROR_ENABLED=${VT_WERROR_ENABLED} \
     VT_POOL_ENABLED=${VT_POOL_ENABLED} \
     CMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}
 

ci/docker/ubuntu-18.04-clang-cpp.dockerfile

@@ -58,6 +58,7 @@ ARG VT_TRACE_RUNTIME_ENABLED
 ARG VT_MIMALLOC_ENABLED
 ARG VT_DOXYGEN_ENABLED
 ARG VT_ASAN_ENABLED
+ARG VT_WERROR_ENABLED
 ARG VT_POOL_ENABLED
 ARG CMAKE_BUILD_TYPE
 ARG VT_EXTENDED_TESTS_ENABLED
@@ -68,6 +69,7 @@ ENV VT_LB_ENABLED=${VT_LB_ENABLED} \
     VT_DOXYGEN_ENABLED=${VT_DOXYGEN_ENABLED} \
     VT_TRACE_RUNTIME_ENABLED=${VT_TRACE_RUNTIME} \
     VT_ASAN_ENABLED=${VT_ASAN_ENABLED} \
+    VT_WERROR_ENABLED=${VT_WERROR_ENABLED} \
     VT_POOL_ENABLED=${VT_POOL_ENABLED} \
     VT_MPI_GUARD_ENABLED=${VT_MPI_GUARD_ENABLED} \
     VT_EXTENDED_TESTS_ENABLED=${VT_EXTENDED_TESTS_ENABLED} \

ci/docker/ubuntu-18.04-gnu-cpp.dockerfile

@@ -84,6 +84,7 @@ ARG VT_TRACE_RUNTIME_ENABLED
 ARG VT_MIMALLOC_ENABLED
 ARG VT_DOXYGEN_ENABLED
 ARG VT_ASAN_ENABLED
+ARG VT_WERROR_ENABLED
 ARG VT_POOL_ENABLED
 ARG VT_ZOLTAN_ENABLED
 ARG CMAKE_BUILD_TYPE
@@ -95,6 +96,7 @@ ENV VT_LB_ENABLED=${VT_LB_ENABLED} \
     VT_DOXYGEN_ENABLED=${VT_DOXYGEN_ENABLED} \
     VT_TRACE_RUNTIME_ENABLED=${VT_TRACE_RUNTIME} \
     VT_ASAN_ENABLED=${VT_ASAN_ENABLED} \
+    VT_WERROR_ENABLED=${VT_WERROR_ENABLED} \
     VT_POOL_ENABLED=${VT_POOL_ENABLED} \
     VT_MPI_GUARD_ENABLED=${VT_MPI_GUARD_ENABLED} \
     VT_ZOLTAN_ENABLED=${VT_ZOLTAN_ENABLED} \

ci/docker/ubuntu-18.04-gnu-docs.dockerfile

@@ -50,6 +50,7 @@ ARG VT_TRACE_RUNTIME_ENABLED
 ARG VT_MIMALLOC_ENABLED
 ARG VT_DOXYGEN_ENABLED
 ARG VT_ASAN_ENABLED
+ARG VT_WERROR_ENABLED
 ARG VT_POOL_ENABLED
 ARG CMAKE_BUILD_TYPE
 ARG VT_EXTENDED_TESTS_ENABLED
@@ -60,6 +61,7 @@ ENV VT_LB_ENABLED=${VT_LB_ENABLED} \
     VT_DOXYGEN_ENABLED=${VT_DOXYGEN_ENABLED} \
     VT_TRACE_RUNTIME_ENABLED=${VT_TRACE_RUNTIME} \
     VT_ASAN_ENABLED=${VT_ASAN_ENABLED} \
+    VT_WERROR_ENABLED=${VT_WERROR_ENABLED} \
     VT_POOL_ENABLED=${VT_POOL_ENABLED} \
     VT_MPI_GUARD_ENABLED=${VT_MPI_GUARD_ENABLED} \
     VT_EXTENDED_TESTS_ENABLED=${VT_EXTENDED_TESTS_ENABLED} \

ci/docker/ubuntu-18.04-intel-cpp.dockerfile

@@ -59,6 +59,7 @@ ARG VT_TRACE_RUNTIME_ENABLED
 ARG VT_MIMALLOC_ENABLED
 ARG VT_DOXYGEN_ENABLED
 ARG VT_ASAN_ENABLED
+ARG VT_WERROR_ENABLED
 ARG VT_POOL_ENABLED
 ARG CMAKE_BUILD_TYPE
 ARG VT_EXTENDED_TESTS_ENABLED
@@ -69,6 +70,7 @@ ENV VT_LB_ENABLED=${VT_LB_ENABLED} \
     VT_DOXYGEN_ENABLED=${VT_DOXYGEN_ENABLED} \
     VT_TRACE_RUNTIME_ENABLED=${VT_TRACE_RUNTIME} \
     VT_ASAN_ENABLED=${VT_ASAN_ENABLED} \
+    VT_WERROR_ENABLED=${VT_WERROR_ENABLED} \
     VT_POOL_ENABLED=${VT_POOL_ENABLED} \
     VT_MPI_GUARD_ENABLED=${VT_MPI_GUARD_ENABLED} \
     VT_EXTENDED_TESTS_ENABLED=${VT_EXTENDED_TESTS_ENABLED} \

ci/docker/ubuntu-18.04-nvidia-cpp.dockerfile

@@ -90,6 +90,7 @@ ARG VT_TRACE_RUNTIME_ENABLED
 ARG VT_MIMALLOC_ENABLED
 ARG VT_DOXYGEN_ENABLED
 ARG VT_ASAN_ENABLED
+ARG VT_WERROR_ENABLED
 ARG VT_POOL_ENABLED
 ARG CMAKE_BUILD_TYPE
 ARG VT_EXTENDED_TESTS_ENABLED
@@ -100,6 +101,7 @@ ENV VT_LB_ENABLED=${VT_LB_ENABLED} \
     VT_DOXYGEN_ENABLED=${VT_DOXYGEN_ENABLED} \
     VT_TRACE_RUNTIME_ENABLED=${VT_TRACE_RUNTIME} \
     VT_ASAN_ENABLED=${VT_ASAN_ENABLED} \
+    VT_WERROR_ENABLED=${VT_WERROR_ENABLED} \
     VT_POOL_ENABLED=${VT_POOL_ENABLED} \
     VT_EXTENDED_TESTS_ENABLED=${VT_EXTENDED_TESTS_ENABLED} \
     VT_UNITY_BUILD_ENABLED=${VT_UNITY_BUILD_ENABLED} \

ci/docker/ubuntu-20.04-clang-cpp.dockerfile

@@ -58,6 +58,7 @@ ARG VT_TRACE_RUNTIME_ENABLED
 ARG VT_MIMALLOC_ENABLED
 ARG VT_DOXYGEN_ENABLED
 ARG VT_ASAN_ENABLED
+ARG VT_WERROR_ENABLED
 ARG VT_POOL_ENABLED
 ARG CMAKE_BUILD_TYPE
 ARG VT_EXTENDED_TESTS_ENABLED
@@ -68,6 +69,7 @@ ENV VT_LB_ENABLED=${VT_LB_ENABLED} \
     VT_DOXYGEN_ENABLED=${VT_DOXYGEN_ENABLED} \
     VT_TRACE_RUNTIME_ENABLED=${VT_TRACE_RUNTIME} \
     VT_ASAN_ENABLED=${VT_ASAN_ENABLED} \
+    VT_WERROR_ENABLED=${VT_WERROR_ENABLED} \
     VT_POOL_ENABLED=${VT_POOL_ENABLED} \
     VT_MPI_GUARD_ENABLED=${VT_MPI_GUARD_ENABLED} \
     VT_EXTENDED_TESTS_ENABLED=${VT_EXTENDED_TESTS_ENABLED} \

ci/docker/ubuntu-20.04-gnu-cpp.dockerfile

@@ -78,6 +78,7 @@ ARG VT_TRACE_RUNTIME_ENABLED
 ARG VT_MIMALLOC_ENABLED
 ARG VT_DOXYGEN_ENABLED
 ARG VT_ASAN_ENABLED
+ARG VT_WERROR_ENABLED
 ARG VT_POOL_ENABLED
 ARG VT_ZOLTAN_ENABLED
 ARG CMAKE_BUILD_TYPE
@@ -89,6 +90,7 @@ ENV VT_LB_ENABLED=${VT_LB_ENABLED} \
     VT_DOXYGEN_ENABLED=${VT_DOXYGEN_ENABLED} \
     VT_TRACE_RUNTIME_ENABLED=${VT_TRACE_RUNTIME} \
     VT_ASAN_ENABLED=${VT_ASAN_ENABLED} \
+    VT_WERROR_ENABLED=${VT_WERROR_ENABLED} \
     VT_POOL_ENABLED=${VT_POOL_ENABLED} \
     VT_MPI_GUARD_ENABLED=${VT_MPI_GUARD_ENABLED} \
     VT_ZOLTAN_ENABLED=${VT_ZOLTAN_ENABLED} \

ci/docker/ubuntu-20.04-gnu-openmpi-cpp.dockerfile

@@ -82,6 +82,7 @@ ARG VT_TRACE_RUNTIME_ENABLED
 ARG VT_MIMALLOC_ENABLED
 ARG VT_DOXYGEN_ENABLED
 ARG VT_ASAN_ENABLED
+ARG VT_WERROR_ENABLED
 ARG VT_POOL_ENABLED
 ARG VT_ZOLTAN_ENABLED
 ARG CMAKE_BUILD_TYPE
@@ -93,6 +94,7 @@ ENV VT_LB_ENABLED=${VT_LB_ENABLED} \
     VT_DOXYGEN_ENABLED=${VT_DOXYGEN_ENABLED} \
     VT_TRACE_RUNTIME_ENABLED=${VT_TRACE_RUNTIME} \
     VT_ASAN_ENABLED=${VT_ASAN_ENABLED} \
+    VT_WERROR_ENABLED=${VT_WERROR_ENABLED} \
     VT_POOL_ENABLED=${VT_POOL_ENABLED} \
     VT_MPI_GUARD_ENABLED=${VT_MPI_GUARD_ENABLED} \
     VT_ZOLTAN_ENABLED=${VT_ZOLTAN_ENABLED} \

cmake-modules/SetCXXCompilerFlags.cmake

@@ -18,6 +18,9 @@ elseif ("${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang")
   if (CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 7 OR CMAKE_CXX_COMPILER_VERSION VERSION_EQUAL 7)
     list(APPEND CXX_STANDARD_FLAGS -DCLI11_EXPERIMENTAL_OPTIONAL=0)
   endif()
+  if (CMAKE_CXX_COMPILER_VERSION VERSION_LESS 6)
+    list(APPEND CXX_STANDARD_FLAGS -Wno-missing-braces)
+  endif()
 elseif ("${CMAKE_CXX_COMPILER_ID}" MATCHES "Intel")
   # 16.0.3 complains about std::min not being constexpr
   set(${CXX_STANDARD_FLAGS} -std=c++14)

docker-compose.yml

@@ -26,6 +26,7 @@
 #   VT_DOCS=0                 # Enable doxygen build
 #   VT_TRACE_RT=0             # Enable tracing at runtime (for testing)
 #   VT_ASAN=0                 # Enable address sanitizer
+#   VT_WERROR=1               # Treat all warnings as errors
 #   VT_EXTENDED_TESTS=1       # Build all the extended testing
 #   VT_ZOLTAN=0               # Build with Zoltan enabled
 #   VT_UNITY_BUILD=0          # Build with Unity/Jumbo mode enabled
@@ -123,6 +124,7 @@ x-vtopts: &vtopts
   VT_DOXYGEN_ENABLED: ${VT_DOCS:-0}
   VT_TRACE_RUNTIME_ENABLED: ${VT_TRACE_RT:-0}
   VT_ASAN_ENABLED: ${VT_ASAN:-0}
+  VT_WERROR_ENABLED: ${VT_WERROR:-1}
   VT_POOL_ENABLED: ${VT_POOL:-1}
   VT_ZOLTAN_ENABLED: ${VT_ZOLTAN:-0}
   VT_UNITY_BUILD_ENABLED: ${VT_UNITY_BUILD:-0}

docs/md/building.md

@@ -49,6 +49,7 @@ build configuration:
 | `vt_doxygen_enabled`             | 0               | Enable doxygen generation |
 | `vt_mimalloc_enabled`            | 0               | Enable `mimalloc`, alternative allocator for debugging memory usage/frees/corruption |
 | `vt_asan_enabled`                | 0               | Enable building with address sanitizer |
+| `vt_werror_enabled`              | 0               | Treat all warnings as errors |
 | `vt_pool_enabled`                | 1               | Use memory pool in *vt* for message allocation |
 | `vt_zoltan_enabled`              | 0               | Build with Zoltan enabled for `ZoltanLB` support |
 | `vt_mpi_guards`                  | 0               | Guards against mis-use of MPI calls in code using *vt* |
@@ -81,6 +82,7 @@ parameters.
 | `VT_DOXYGEN_ENABLED `            | 0               | Enable doxygen generation |
 | `VT_MIMALLOC_ENABLED `           | 0               | Enable `mimalloc`, alternative allocator for debugging memory usage/frees/corruption |
 | `VT_ASAN_ENABLED `               | 0               | Enable building with address sanitizer |
+| `VT_WERROR_ENABLED `             | 0               | Treat all warnings as errors |
 | `VT_POOL_ENABLED `               | 1               | Use memory pool in *vt* for message allocation |
 | `VT_ZOLTAN_ENABLED `             | 0               | Build with Zoltan enabled for `ZoltanLB` support |
 | `ZOLTAN_DIR `                    | <empty>         | Directory pointing to Zoltan installation |
@@ -146,6 +148,7 @@ which `docker-compose` will read.
 #   VT_DOCS=0                 # Enable doxygen build
 #   VT_TRACE_RT=0             # Enable tracing at runtime (for testing)
 #   VT_ASAN=0                 # Enable address sanitizer
+#   VT_WERROR=1               # Treat all warnings as errors
 #   VT_EXTENDED_TESTS=1       # Build all the extended testing
 #   VT_ZOLTAN=0               # Build with Zoltan enabled
 #   VT_UNITY_BUILD=0          # Build with Unity/Jumbo mode enabled