-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1173: omp_lock_t is undefined on Intel serial build #1214
Conversation
b82ad6e fixes following warnings:
note: this is specific to libfort and thus is only an optional |
Codecov Report
@@ Coverage Diff @@
## develop #1214 +/- ##
===========================================
- Coverage 81.25% 80.86% -0.40%
===========================================
Files 738 729 -9
Lines 28211 27976 -235
===========================================
- Hits 22923 22622 -301
- Misses 5288 5354 +66
|
@cz4rs I found this -> https://community.intel.com/t5/Intel-C-Compiler/Cause-for-remark-11074-Inlining-inhibited-by-limit-max-size/td-p/1073635 regarding Intel's remarks (I'm not sure if we want to ignore them or not):
|
b82ad6e
to
263f543
Compare
PR tests (gcc-5, ubuntu, mpich)
|
PR tests (intel 19, ubuntu, mpich)
|
PR tests (intel 18.03, ubuntu, mpich)
|
PR tests (nvidia cuda 10.1, ubuntu, mpich)
|
PR tests (nvidia cuda 11.0, ubuntu, mpich)
|
263f543
to
162b7b3
Compare
PR tests (nvidia cuda 10.1, ubuntu, mpich)
|
PR tests (nvidia cuda 11.0, ubuntu, mpich)
|
162b7b3
to
663ce72
Compare
PR tests (nvidia cuda 10.1, ubuntu, mpich)
|
PR tests (nvidia cuda 11.0, ubuntu, mpich)
|
PR tests (clang-5.0, ubuntu, mpich)
|
PR tests (clang-3.9, ubuntu, mpich)
|
PR tests (gcc-5, ubuntu, mpich)
|
PR tests (gcc-8, ubuntu, mpich, address sanitizer)
|
PR tests (gcc-10, ubuntu, openmpi, no LB)
|
PR tests (gcc-6, ubuntu, mpich)
|
PR tests (gcc-9, ubuntu, mpich, zoltan)
|
PR tests (clang-8, alpine, mpich)
|
PR tests (nvidia cuda 10.1, ubuntu, mpich)
|
PR tests (nvidia cuda 11.0, ubuntu, mpich)
|
PR tests (intel 19, ubuntu, mpich)
|
PR tests (intel 18.03, ubuntu, mpich)
|
PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)
|
a0f3c88
to
3fa5d18
Compare
- add configuration variables for threading (Docker and script, CMake already has them) - update documentation accordingly
aec5d3e
to
8a23226
Compare
8a23226
to
f166c59
Compare
no threading is the default behavior now currently there is no |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me
regarding rebuilding docker images when needed: it doesn't seem to be possible with an alternative would be to just look at the git diff and detect changes in Dockerfiles note to self: how to get the list of files changed: |
fixes #1173