883: Make broadcast deliver to sender (for default group) #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobDomagala
force-pushed
the
883-make-bcast-deliver-to-sender
branch
2 times, most recently
from
67c5b6f to
d386c5c
Compare
JacobDomagala
force-pushed
the
883-make-bcast-deliver-to-sender
branch
2 times, most recently
from
590e018 to
5b58faf
Compare
JacobDomagala
force-pushed
the
883-make-bcast-deliver-to-sender
branch
3 times, most recently
from
a518499 to
647c43b
Compare
JacobDomagala
force-pushed
the
883-make-bcast-deliver-to-sender
branch
from
ca70159 to
ccd8b6c
Compare
JacobDomagala
force-pushed
the
883-make-bcast-deliver-to-sender
branch
from
ccd8b6c to
0ec1ae8
Compare
|
PR tests (gcc-5, ubuntu, mpich) Build for 73b7e8c |
|
PR tests (clang-3.9, ubuntu, mpich) Build for 73b7e8c |
|
PR tests (clang-5.0, ubuntu, mpich) Build for 73b7e8c |
|
PR tests (gcc-10, ubuntu, openmpi, no LB) Build for 73b7e8c |
|
PR tests (gcc-7, ubuntu, mpich, trace runtime, LB) Build for 73b7e8c |
|
PR tests (gcc-6, ubuntu, mpich) Build for 73b7e8c |
|
PR tests (gcc-8, ubuntu, mpich, address sanitizer) Build for 73b7e8c |
|
PR tests (gcc-9, ubuntu, mpich, zoltan) Build for 73b7e8c |
…m sys_msg to user_msg so it can be later used in user handler
…since now sender will always execute the handler
…sent to default group should be delivered to sender
…of invoking it inline
JacobDomagala
force-pushed
the
883-make-bcast-deliver-to-sender
branch
from
0ec1ae8 to
c166484
Compare
|
PR tests (intel 19, ubuntu, mpich) Build for 73b7e8c |
|
PR tests (clang-8, alpine, mpich) Build for 73b7e8c |
PhilMiller
reviewed
Feb 23, 2021
| @@ -98,6 +98,10 @@ struct ActiveEnvelope { | |||
| /// True iff the message is considered locked. | |||
| /// If locked, changes to the envelope will result in failure. | |||
| bool is_locked : 1; | |||
|
|
|||
| // Used only for broadcast to default group | |||
| // Determines whether message should be send also to sender | |||
There was a problem hiding this comment.
Reword please:
"Determines whether message should also be sent to the sender"
PhilMiller
approved these changes
Feb 23, 2021
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #883