Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1763 build only ready prs #1785

Merged
merged 13 commits into from
Jul 8, 2022
Merged

#1763 build only ready prs #1785

merged 13 commits into from
Jul 8, 2022

Conversation

jstrzebonski
Copy link
Contributor

@jstrzebonski jstrzebonski commented May 9, 2022 •
edited
Loading

Fixes #1763

TODO:

  • Run build only if PR is ready for review
  • Cancel ongoing builds when new code is pushed
  • Cancel ongoing builds when new code is pushed on macOS pipeline
  • Turn off building drafts for macOS pipeline
  • Allow running builds even if PR is in draft mode - maybe by a special comment or label? - Cannot be done in any satisfactory way.
  • Add a label that, if absent, blocks PR from being merged - moved to Gitlab CI integration with pipelines #1861

@jstrzebonski jstrzebonski self-assigned this May 9, 2022
@jstrzebonski jstrzebonski force-pushed the 1763-build-only-ready-prs branch 2 times, most recently from 5c907a6 to 72a978a Compare May 9, 2022 15:25
@jstrzebonski jstrzebonski force-pushed the 1763-build-only-ready-prs branch from 72a978a to ab06be3 Compare May 11, 2022 12:26
@jstrzebonski jstrzebonski added ready-to-merge Marks PR as ready to merge and removed ready-to-merge Marks PR as ready to merge labels May 11, 2022
@jstrzebonski jstrzebonski force-pushed the 1763-build-only-ready-prs branch from 947823c to 0e2ee1e Compare May 11, 2022 14:21
@jstrzebonski jstrzebonski added ready-to-merge Marks PR as ready to merge and removed ready-to-merge Marks PR as ready to merge labels May 11, 2022
@jstrzebonski jstrzebonski force-pushed the 1763-build-only-ready-prs branch 2 times, most recently from 1e15705 to f6f8629 Compare May 20, 2022 05:13
@jstrzebonski jstrzebonski added the ready-to-merge Marks PR as ready to merge label May 20, 2022
@codecov
Copy link

codecov bot commented May 20, 2022 •
edited
Loading

Codecov Report

Merging #1785 (47a6d99) into develop (5e59031) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 47a6d99 differs from pull request most recent head baa8413. Consider uploading reports for the commit baa8413 to get more accurate results

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1785   +/-   ##
========================================
  Coverage    84.37%   84.37%           
========================================
  Files          760      760           
  Lines        26791    26791           
========================================
+ Hits         22604    22606    +2     
+ Misses        4187     4185    -2
Impacted Files Coverage Δ
src/vt/phase/phase_manager.cc 94.11% <0.00%> (+1.68%) ⬆️

@jstrzebonski jstrzebonski added ready-to-merge Marks PR as ready to merge and removed ready-to-merge Marks PR as ready to merge labels May 20, 2022
@jstrzebonski jstrzebonski marked this pull request as ready for review May 20, 2022 10:16
@jstrzebonski jstrzebonski added ready-to-merge Marks PR as ready to merge and removed ready-to-merge Marks PR as ready to merge labels Jun 24, 2022
@jstrzebonski jstrzebonski requested a review from thearusable June 24, 2022 14:11
cz4rs
cz4rs approved these changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@cz4rs cz4rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jstrzebonski jstrzebonski force-pushed the 1763-build-only-ready-prs branch 3 times, most recently from 67daa5e to 7ddd04e Compare June 28, 2022 12:12
@jstrzebonski
Copy link
Contributor Author

Marking as a draft until I move last commit to a new branch.

@jstrzebonski jstrzebonski marked this pull request as draft June 28, 2022 17:39
@jstrzebonski jstrzebonski force-pushed the 1763-build-only-ready-prs branch from 7ddd04e to 30d8f65 Compare July 4, 2022 09:59
@jstrzebonski
Copy link
Contributor Author

Marking as a draft until I move last commit to a new branch.

Done.

@jstrzebonski jstrzebonski removed the ready-to-merge Marks PR as ready to merge label Jul 4, 2022
@jstrzebonski jstrzebonski marked this pull request as ready for review July 5, 2022 17:13
@jstrzebonski jstrzebonski force-pushed the 1763-build-only-ready-prs branch from 30d8f65 to baa8413 Compare July 5, 2022 17:47
@nlslatt nlslatt merged commit edebf58 into develop Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlslatt nlslatt nlslatt approved these changes

@JacobDomagala JacobDomagala JacobDomagala approved these changes

@cz4rs cz4rs cz4rs approved these changes

@lifflander lifflander Awaiting requested review from lifflander

@nmm0 nmm0 Awaiting requested review from nmm0

@PhilMiller PhilMiller Awaiting requested review from PhilMiller

@thearusable thearusable Awaiting requested review from thearusable

Assignees

@jstrzebonski jstrzebonski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Only run CI automatically when PR is not in draft mode
4 participants
@jstrzebonski @nlslatt @cz4rs @JacobDomagala