Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1849: Add simple unit test for AsyncOpCUDA #1855

Merged
merged 6 commits into from
Nov 29, 2022
Merged

1849: Add simple unit test for AsyncOpCUDA #1855

merged 6 commits into from
Nov 29, 2022

Conversation

JacobDomagala
Copy link
Contributor

Fixes #1849

@github-actions
Copy link

github-actions bot commented Jun 16, 2022 •
edited
Loading

Pipelines results

PR tests (gcc-6, ubuntu, mpich)

Build for 6a9bf88 (2022-11-15 18:22:32 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-5, ubuntu, mpich)

Build for 6a9bf88 (2022-11-15 18:22:32 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (nvidia cuda 10.1, ubuntu, mpich)

Build for 6a9bf88 (2022-11-15 18:22:32 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-3.9, ubuntu, mpich)

Build for 6a9bf88 (2022-11-15 18:22:32 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-5.0, ubuntu, mpich)

Build for 6a9bf88 (2022-11-15 18:22:32 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for 6a9bf88 (2022-11-15 18:22:32 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for 6a9bf88 (2022-11-15 18:22:32 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for 6a9bf88 (2022-11-15 18:22:32 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-9, ubuntu, mpich)

Build for 6a9bf88 (2022-11-15 18:22:32 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-13, alpine, mpich)

Build for 6a9bf88 (2022-11-15 18:22:32 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for 6a9bf88 (2022-11-15 18:22:32 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-11, ubuntu, mpich)

Build for 6a9bf88 (2022-11-15 18:22:32 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (intel icpx, ubuntu, mpich)

Build for 6a9bf88 (2022-11-15 18:22:32 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for 6a9bf88 (2022-11-15 18:22:32 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-14, ubuntu, mpich)

Build for 6a9bf88 (2022-11-15 18:22:32 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-11, ubuntu, mpich)

Build for 2783380

Compilation - successful

Testing - passed

Build log

PR tests (clang-12, ubuntu, mpich)

Build for 6a9bf88 (2022-11-15 18:22:32 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-12, ubuntu, mpich)

Build for a7eabb0 (2022-10-25 18:59:36 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (intel icpc, ubuntu, mpich)

Build for 6a9bf88 (2022-11-15 18:22:32 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-10, ubuntu, mpich)

Build for 6a9bf88 (2022-11-15 18:22:32 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-13, ubuntu, mpich)

Build for 6a9bf88 (2022-11-15 18:22:32 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-11, ubuntu, mpich, json schema test)

Build for 6a9bf88 (2022-11-15 18:22:32 UTC)

Compilation - successful

Testing - passed

Build log

@codecov
Copy link

codecov bot commented Jun 16, 2022 •
edited
Loading

Codecov Report

Merging #1855 (a35ef08) into develop (2a77163) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1855   +/-   ##
========================================
  Coverage    84.47%   84.47%           
========================================
  Files          731      731           
  Lines        25860    25860           
========================================
  Hits         21845    21845           
  Misses        4015     4015
Impacted Files Coverage Δ
tests/unit/active/test_async_op_mpi.cc 100.00% <ø> (ø)

@JacobDomagala JacobDomagala force-pushed the 1849-add-unit-test-for-asyncop-cuda branch 2 times, most recently from 47270a5 to e674cff Compare June 19, 2022 21:11
JacobDomagala
JacobDomagala commented Jun 21, 2022
View reviewed changes
tests/unit/active/test_async_op_cuda.cc Outdated
Comment on lines 183 to 195
int driverVer;
if (
(cudaDriverGetVersion(&driverVer) == cudaErrorInvalidValue) or
(driverVer == 0)) {
vtWarn(
"Trying to run test_async_op_cuda but CUDA driver is not present!\n"
);

return;
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since Azure runners don't have CUDA driver installed, we don't want to run the test (but we still want to compile the file, so we don't exclude it with vt_ci_build or something similar)

@JacobDomagala JacobDomagala marked this pull request as ready for review June 21, 2022 16:53
@nlslatt nlslatt mentioned this pull request Jun 21, 2022
Open
@JacobDomagala JacobDomagala force-pushed the 1849-add-unit-test-for-asyncop-cuda branch from e674cff to 4f36793 Compare June 28, 2022 19:58
@JacobDomagala JacobDomagala force-pushed the 1849-add-unit-test-for-asyncop-cuda branch from 4f36793 to b6d30ec Compare July 12, 2022 17:02
@lifflander lifflander self-requested a review July 12, 2022 17:24
@JacobDomagala JacobDomagala force-pushed the 1849-add-unit-test-for-asyncop-cuda branch from b6d30ec to f190105 Compare July 14, 2022 21:31
nlslatt
nlslatt reviewed Jul 15, 2022
View reviewed changes
Copy link
Collaborator

@nlslatt nlslatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this manually on Vortex. If I build with g++, the test is not compiled. If I do a cuda build on the login node and then run on the compute node, the test passes.

If I accidentally run it on the login node instead, it aborts with cudaMalloc(dataDevicePointer1_) failed with error -> initialization error. Is that the desired behavior, or was this use case meant to be handled with GTEST_SKIP?

@JacobDomagala JacobDomagala force-pushed the 1849-add-unit-test-for-asyncop-cuda branch 2 times, most recently from 7318ec7 to 2783380 Compare September 9, 2022 13:01
@JacobDomagala JacobDomagala changed the title #1849: Add simple unit test for AsyncOpCUDA 1849: Add simple unit test for AsyncOpCUDA Sep 13, 2022
@JacobDomagala JacobDomagala force-pushed the 1849-add-unit-test-for-asyncop-cuda branch from 2783380 to a7eabb0 Compare October 25, 2022 18:59
@JacobDomagala JacobDomagala force-pushed the 1849-add-unit-test-for-asyncop-cuda branch 2 times, most recently from 44f9759 to 6a9bf88 Compare November 15, 2022 18:23
@JacobDomagala JacobDomagala force-pushed the 1849-add-unit-test-for-asyncop-cuda branch from 6a9bf88 to a35ef08 Compare November 29, 2022 18:53
@JacobDomagala
Copy link
Contributor Author

Ok, rebased the branch

@PhilMiller PhilMiller merged commit a12fd45 into develop Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlslatt nlslatt nlslatt left review comments

@lifflander lifflander lifflander approved these changes

@PhilMiller PhilMiller PhilMiller approved these changes

@cz4rs cz4rs Awaiting requested review from cz4rs

@jstrzebonski jstrzebonski Awaiting requested review from jstrzebonski

@stmcgovern stmcgovern Awaiting requested review from stmcgovern

@thearusable thearusable Awaiting requested review from thearusable

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add unit test for CUDA AsyncOp
4 participants
@JacobDomagala @PhilMiller @lifflander @nlslatt