Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1908: Disable preConfig #1924

Merged
merged 3 commits into from
Aug 30, 2022

Conversation

stmcgovern
Copy link
Contributor

Closes #1908.

@github-actions
Copy link

github-actions bot commented Aug 23, 2022

Pipelines results

PR tests (gcc-5, ubuntu, mpich)

Build for a1731b6

Compilation - successful

Testing - passed

Build log


PR tests (clang-3.9, ubuntu, mpich)

Build for a1731b6

Compilation - successful

Testing - passed

Build log


PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for a1731b6

Compilation - successful

Testing - passed

Build log


PR tests (gcc-6, ubuntu, mpich)

Build for a1731b6

Compilation - successful

Testing - passed

Build log


PR tests (clang-5.0, ubuntu, mpich)

Build for a1731b6

Compilation - successful

Testing - passed

Build log


PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for a1731b6

Compilation - successful

Testing - passed

Build log


PR tests (clang-9, ubuntu, mpich)

Build for a1731b6

Compilation - successful

Testing - passed

Build log


PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for a1731b6

Compilation - successful

Testing - passed

Build log


PR tests (clang-13, alpine, mpich)

Build for a1731b6

Compilation - successful

Testing - passed

Build log


PR tests (intel icpx, ubuntu, mpich)

Build for a1731b6

Compilation - successful

Testing - passed

Build log


PR tests (nvidia cuda 10.1, ubuntu, mpich)

Build for a1731b6

Compilation - successful

Testing - passed

Build log


PR tests (clang-11, ubuntu, mpich)

Build for a1731b6

Compilation - successful

Testing - passed

Build log


PR tests (clang-12, ubuntu, mpich)

Build for a1731b6

Compilation - successful

Testing - passed

Build log


PR tests (clang-14, ubuntu, mpich)

Build for a1731b6

Compilation - successful

Testing - passed

Build log


PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for a1731b6

Compilation - successful

Testing - passed

Build log


PR tests (gcc-11, ubuntu, mpich)

Build for a1731b6

Compilation - successful

Testing - passed

Build log


PR tests (clang-10, ubuntu, mpich)

Build for a1731b6

Compilation - successful

Testing - passed

Build log


PR tests (clang-13, ubuntu, mpich)

Build for a1731b6

Compilation - successful

Testing - passed

Build log


PR tests (gcc-12, ubuntu, mpich)

Build for a1731b6

Compilation - successful

Testing - passed

Build log


PR tests (intel icpc, ubuntu, mpich)

Build for a1731b6

Compilation - successful

Testing - passed

Build log


@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #1924 (b0670a4) into develop (ff3ec68) will not change coverage.
The diff coverage is n/a.

❗ Current head b0670a4 differs from pull request most recent head a1731b6. Consider uploading reports for the commit a1731b6 to get more accurate results

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1924   +/-   ##
========================================
  Coverage    84.39%   84.39%           
========================================
  Files          761      761           
  Lines        26866    26866           
========================================
  Hits         22673    22673           
  Misses        4193     4193           
Impacted Files Coverage Δ
src/vt/configs/debug/debug_print.h 100.00% <ø> (ø)
src/vt/messaging/active.cc 86.90% <0.00%> (-0.03%) ⬇️
src/vt/runtime/runtime.cc 75.64% <0.00%> (+0.05%) ⬆️

@stmcgovern
Copy link
Contributor Author

From grouped PR, see:
#1916 (comment)

Copy link
Member

@PhilMiller PhilMiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you pick up my suggestion from the earlier combined PR?

@stmcgovern stmcgovern force-pushed the 1908-disable-debug-print-preconfig-evaluation branch from b0670a4 to ec521f8 Compare August 24, 2022 00:31
@stmcgovern stmcgovern requested a review from PhilMiller August 24, 2022 00:38
@PhilMiller PhilMiller force-pushed the 1908-disable-debug-print-preconfig-evaluation branch from d071adb to a1731b6 Compare August 30, 2022 17:33
@PhilMiller PhilMiller merged commit 825ce69 into develop Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable debug print preConfig evaulation when in production mode
3 participants