Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1920 update mac build #1981

Merged
merged 1 commit into from
Dec 27, 2022
Merged

1920 update mac build #1981

merged 1 commit into from
Dec 27, 2022

Conversation

lifflander
Copy link
Collaborator

@lifflander lifflander commented Sep 26, 2022 •
edited
Loading

Fixes #1920

@lifflander lifflander changed the base branch from develop to 1899-improve-makerunnable-allocation-performance-new-variant September 26, 2022 20:03
@github-actions
Copy link

github-actions bot commented Sep 26, 2022 •
edited
Loading

Pipelines results

PR tests (gcc-12, ubuntu, mpich)

Build for bd58114

Compilation - successful

Testing - passed

Build log

@lifflander lifflander force-pushed the 1920-update-mac-build branch from df9a0b8 to bd58114 Compare September 26, 2022 23:31
@lifflander lifflander force-pushed the 1899-improve-makerunnable-allocation-performance-new-variant branch from c7df3b9 to ba19bad Compare September 27, 2022 17:06
@lifflander lifflander force-pushed the 1920-update-mac-build branch from bd58114 to bdcf086 Compare December 6, 2022 21:36
@lifflander lifflander changed the base branch from 1899-improve-makerunnable-allocation-performance-new-variant to develop December 6, 2022 21:36
@thearusable thearusable force-pushed the 1920-update-mac-build branch from bdcf086 to 91b8af9 Compare December 8, 2022 15:08
@thearusable
Copy link
Contributor

thearusable commented Dec 9, 2022 •
edited
Loading

Looks like macos jobs is working fine now: https://github.com/DARMA-tasking/vt/actions/runs/3656549949/jobs/6179120775

@thearusable thearusable force-pushed the 1920-update-mac-build branch from ad51c92 to e443cef Compare December 9, 2022 10:27
@thearusable thearusable marked this pull request as ready for review December 9, 2022 11:43
@codecov
Copy link

codecov bot commented Dec 9, 2022 •
edited
Loading

Codecov Report

Merging #1981 (ee7c24b) into develop (7e647e7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1981   +/-   ##
========================================
  Coverage    84.46%   84.46%           
========================================
  Files          729      729           
  Lines        25846    25846           
========================================
  Hits         21831    21831           
  Misses        4015     4015
Impacted Files Coverage Δ
src/vt/phase/phase_manager.cc 89.86% <0.00%> (-1.36%) ⬇️
src/vt/messaging/request_holder.h 76.92% <0.00%> (+7.69%) ⬆️

@thearusable thearusable self-assigned this Dec 9, 2022
cz4rs
cz4rs approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@cz4rs cz4rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
I think that using latest instead of a fixed version is fine here, new version of macos doesn't show up too often ;)

nlslatt
nlslatt previously requested changes Dec 9, 2022
View reviewed changes
Copy link
Collaborator

@nlslatt nlslatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NOMERGE commits need to be rebased out.

@nlslatt
Copy link
Collaborator

nlslatt commented Dec 12, 2022

The NOMERGE commits need to be rebased out.

In the interests of getting this merged, I'm going to squash the commits to eliminate the NOMERGE problem and all the extraneous debugging commits.

@nlslatt nlslatt force-pushed the 1920-update-mac-build branch from dc7ece1 to 4020d07 Compare December 12, 2022 23:38
@nlslatt nlslatt dismissed their stale review December 12, 2022 23:38

Requested change has been made.

@thearusable
Copy link
Contributor

The NOMERGE commits need to be rebased out.

In the interests of getting this merged, I'm going to squash the commits to eliminate the NOMERGE problem and all the extraneous debugging commits.

@nlslatt Thanks! Sorry I somehow missed you previous comment.

@thearusable thearusable force-pushed the 1920-update-mac-build branch 3 times, most recently from 0a415e4 to a93a172 Compare December 13, 2022 11:57
@lifflander lifflander force-pushed the 1920-update-mac-build branch 2 times, most recently from 9258167 to 3bfa4fa Compare December 13, 2022 17:14
@nmm0 nmm0 mentioned this pull request Dec 13, 2022
Open
@thearusable thearusable force-pushed the 1920-update-mac-build branch from 3bfa4fa to ee7c24b Compare December 21, 2022 10:28
@PhilMiller
Copy link
Member

I'm not a huge fan of unspecified 'latest' versions, but the rest of the team has clearly spoken. Merging.

@PhilMiller PhilMiller merged commit da146f2 into develop Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlslatt nlslatt nlslatt approved these changes

@JacobDomagala JacobDomagala JacobDomagala approved these changes

@cz4rs cz4rs cz4rs approved these changes

@thearusable thearusable Awaiting requested review from thearusable

@nmm0 nmm0 Awaiting requested review from nmm0

@PhilMiller PhilMiller Awaiting requested review from PhilMiller

@stmcgovern stmcgovern Awaiting requested review from stmcgovern

Assignees

@thearusable thearusable

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade macOS CI image
6 participants
@lifflander @thearusable @nlslatt @PhilMiller @cz4rs @JacobDomagala