-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1933: Add spec file for LB #1982
Conversation
Pipelines resultsPR tests (gcc-12, ubuntu, mpich) Build for 9061c71
PR tests (clang-3.9, ubuntu, mpich) Build for 9061c71
PR tests (clang-5.0, ubuntu, mpich) Build for 9061c71
PR tests (gcc-6, ubuntu, mpich) Build for 9061c71
PR tests (gcc-10, ubuntu, openmpi, no LB) Build for 9061c71
PR tests (gcc-5, ubuntu, mpich) Build for 9061c71
PR tests (gcc-9, ubuntu, mpich, zoltan) Build for 9061c71
PR tests (nvidia cuda 11.0, ubuntu, mpich) Build for 9061c71
PR tests (clang-9, ubuntu, mpich) Build for 9061c71
PR tests (clang-13, alpine, mpich) Build for 9061c71
PR tests (nvidia cuda 10.1, ubuntu, mpich) Build for 9061c71
PR tests (gcc-8, ubuntu, mpich, address sanitizer) Build for 9061c71
PR tests (clang-11, ubuntu, mpich) Build for 9061c71
PR tests (clang-13, ubuntu, mpich) Build for 9061c71
PR tests (clang-10, ubuntu, mpich) Build for 9061c71
PR tests (intel icpx, ubuntu, mpich) Build for 9061c71
PR tests (clang-14, ubuntu, mpich) Build for 9061c71
PR tests (clang-12, ubuntu, mpich) Build for 9061c71
PR tests (gcc-11, ubuntu, mpich, json schema test) Build for 9061c71
PR tests (intel icpc, ubuntu, mpich) Build for 9061c71
PR tests (gcc-7, ubuntu, mpich, trace runtime, LB) Build for 9061c71
|
566e2e0
to
4aaf7e7
Compare
@JacobDomagala You'll need to re-push now that you've marked this as ready in order for the full PR testing to run. |
4326559
to
566e2e0
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1982 +/- ##
===========================================
+ Coverage 84.35% 84.38% +0.03%
===========================================
Files 730 730
Lines 25569 25644 +75
===========================================
+ Hits 21568 21640 +72
- Misses 4001 4004 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
… used by both Trace and LB
…cause timeout on CI
6b2a117
to
a937c36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add documentation for the format and its usage (you can just point the reader to the trace spec file since the format is the same)? I think it is also important in the documentation to highlight how this is different from the "LB Specification File" (--vt_lb_file_name
)
12f2208
to
9061c71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Fixes #1933