Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1999 Fix icpc/nvcc warnings seen in CDash #2000

Merged
merged 3 commits into from
Oct 18, 2022
Merged

#1999 Fix icpc/nvcc warnings seen in CDash #2000

merged 3 commits into from
Oct 18, 2022

Conversation

PhilMiller
Copy link
Member

@PhilMiller PhilMiller requested a review from nlslatt October 18, 2022 20:04
@PhilMiller
Copy link
Member Author

Draft status until 266 is merged, because the builds will fail

@github-actions
Copy link

github-actions bot commented Oct 18, 2022 •
edited
Loading

Pipelines results

PR tests (gcc-12, ubuntu, mpich)

Build for 08e3950 (2022-10-18 21:02:44 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-5.0, ubuntu, mpich)

Build for 08e3950 (2022-10-18 21:02:44 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for 08e3950 (2022-10-18 21:02:44 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for 08e3950 (2022-10-18 21:02:44 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-5, ubuntu, mpich)

Build for 08e3950 (2022-10-18 21:02:44 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-3.9, ubuntu, mpich)

Build for 08e3950 (2022-10-18 21:02:44 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-6, ubuntu, mpich)

Build for 08e3950 (2022-10-18 21:02:44 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for 08e3950 (2022-10-18 21:02:44 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for 08e3950 (2022-10-18 21:02:44 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-13, alpine, mpich)

Build for 08e3950 (2022-10-18 21:02:44 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-9, ubuntu, mpich)

Build for 08e3950 (2022-10-18 21:02:44 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (nvidia cuda 10.1, ubuntu, mpich)

Build for 08e3950 (2022-10-18 21:02:44 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for 08e3950 (2022-10-18 21:02:44 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-11, ubuntu, mpich)

Build for 08e3950 (2022-10-18 21:02:44 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (intel icpx, ubuntu, mpich)

Build for 08e3950 (2022-10-18 21:02:44 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-13, ubuntu, mpich)

Build for 08e3950 (2022-10-18 21:02:44 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-12, ubuntu, mpich)

Build for 08e3950 (2022-10-18 21:02:44 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-11, ubuntu, mpich, json schema test)

Build for 08e3950 (2022-10-18 21:02:44 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-14, ubuntu, mpich)

Build for 08e3950 (2022-10-18 21:02:44 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-10, ubuntu, mpich)

Build for 08e3950 (2022-10-18 21:02:44 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (intel icpc, ubuntu, mpich)

Build for 08e3950 (2022-10-18 21:02:44 UTC)

Compilation - successful

Testing - passed

Build log

@PhilMiller PhilMiller marked this pull request as ready for review October 18, 2022 20:45
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #2000 (08e3950) into develop (8315da3) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2000      +/-   ##
===========================================
- Coverage    84.38%   84.37%   -0.01%     
===========================================
  Files          730      730              
  Lines        25644    25641       -3     
===========================================
- Hits         21640    21635       -5     
- Misses        4004     4006       +2
Impacted Files Coverage Δ
tests/unit/lb/test_lb_data_comm.cc 100.00% <ø> (ø)
.../unit/collection/test_collection_group.extended.cc 100.00% <100.00%> (ø)
src/vt/phase/phase_manager.cc 89.86% <0.00%> (-1.36%) ⬇️

@PhilMiller PhilMiller merged commit e6b6724 into develop Oct 18, 2022
@PhilMiller PhilMiller deleted the 1999-fix-warnings branch October 18, 2022 23:14
PhilMiller
PhilMiller commented Oct 19, 2022
View reviewed changes
tests/unit/lb/test_lb_data_comm.cc
@@ -762,6 +755,9 @@ TEST_F(TestLBDataComm, test_lb_data_comm_handler_to_handler_send) {
}
}
EXPECT_TRUE(found);

// Suppress warnings about that method being "declared but never referenced" from Intel icpc and Nvidia nvcc
(void)&ReduceMsg::serialize<checkpoint::Serializer>;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be addressed as part of #1316

@PhilMiller
Copy link
Member Author

Success, CDash on develop now builds without warnings!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlslatt nlslatt nlslatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compiler warnings from intel and nvcc
2 participants
@PhilMiller @nlslatt