2045 Switch default builds to C++17 and remove old CUDA build

[lifflander]

Fixes #2045

[codecov]

Codecov Report

Merging #2047 (371c391) into develop (2b66dc0) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 371c391 differs from pull request most recent head 2490172. Consider uploading reports for the commit 2490172 to get more accurate results

@@             Coverage Diff             @@
##           develop    #2047      +/-   ##
===========================================
- Coverage    84.45%   84.43%   -0.03%     
===========================================
  Files          730      729       -1     
  Lines        25842    25832      -10     
===========================================
- Hits         21825    21811      -14     
- Misses        4017     4021       +4     

Impacted Files	Coverage Δ
src/vt/utils/adt/union.h	77.35% <ø> (-1.15%)	⬇️
src/vt/rdma/group/rdma_group.cc	0.00% <0.00%> (-12.50%)	⬇️
src/vt/worker/worker_group_comm.cc	0.00% <0.00%> (-7.15%)	⬇️
src/vt/runtime/component/diagnostic_enum_format.cc	0.00% <0.00%> (-2.71%)	⬇️
src/vt/vrt/collection/balance/read_lb.h	76.66% <0.00%> (-1.46%)	⬇️
src/vt/trace/trace_user_event.cc	37.25% <0.00%> (-1.21%)	⬇️
src/vt/vrt/collection/manager.impl.h	95.49% <0.00%> (-0.99%)	⬇️
src/vt/messaging/async_op_wrapper.cc	90.00% <0.00%> (-0.91%)	⬇️
src/vt/trace/trace_log.h	59.09% <0.00%> (-0.49%)	⬇️
... and 38 more

[cz4rs]

A bunch of warnings promoted to errors in clang builds:

/vt/src/vt/utils/adt/union.h:727:5: error: expression result unused [-Werror,-Wunused-value]

[cz4rs]

Regarding the PR checks (PR description format) failure - possibly a regex didn't expect + character in the branch name?
Also note that the comment aggregating build results / errors is missing.

[thearusable]

Regarding the PR checks (PR description format) failure - possibly a regex didn't expect + character in the branch name?
Also note that the comment aggregating build results / errors is missing.

Yes, regex is not expecting the + character: https://github.com/DARMA-tasking/check-pr-fixes-issue/blob/master/src/helpers.js#L3

[cz4rs]

icpc fails because of:

The following tests FAILED:
	399 - vt:TestPreconfig.test_vt_assert_no_mpi (SEGFAULT)

This might be worth investigating, but on the other hand the log is also littered with:

icpc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '\''-diag-disable=10441'\'' to disable this message.

Can we drop icpc support right now?

[cz4rs]

On the other hand, clang-5.0 failure seems to be directly related to this PR:

In file included from /vt/src/vt/worker/worker_group_comm.cc:45:
/vt/src/vt/context/context.h:225:3: error: non-type template argument refers to subobject '&tls_static_str_thisWorker__'
  DeclareClassInsideInitTLS(Context, WorkerIDType, thisWorker_, no_worker_id)
  ^

[PhilMiller]

For icpc, we'll probably want to pin whatever version of Intel's oneAPI is being supported by Trilinos and used by the Sandia apps.

The clang 5 failure in worker will go away when the removal PR is merged