#2036 Update PerfTestHarness to allow for multiple tests in a single file #2097
Conversation
Pipelines resultsPR tests (gcc-12, ubuntu, mpich) Build for 7d27c8f (2023-06-14 08:17:33 UTC) PR tests (clang-9, ubuntu, mpich) Build for 7d27c8f (2023-06-14 08:17:33 UTC) PR tests (clang-11, ubuntu, mpich) Build for 7d27c8f (2023-06-14 08:17:33 UTC) PR tests (clang-12, ubuntu, mpich) Build for 7d27c8f (2023-06-14 08:17:33 UTC) PR tests (gcc-10, ubuntu, openmpi, no LB) Build for 7d27c8f (2023-06-14 08:17:33 UTC) PR tests (gcc-9, ubuntu, mpich, zoltan, json schema test) Build for 7d27c8f (2023-06-14 08:17:33 UTC) PR tests (gcc-8, ubuntu, mpich, address sanitizer) Build for 7d27c8f (2023-06-14 08:17:33 UTC) PR tests (clang-13, ubuntu, mpich) Build for 7d27c8f (2023-06-14 08:17:33 UTC) PR tests (clang-14, ubuntu, mpich) Build for 7d27c8f (2023-06-14 08:17:33 UTC) PR tests (nvidia cuda 11.0, ubuntu, mpich) Build for 80a2656 (2023-04-05 18:23:24 UTC) PR tests (nvidia cuda 11.2, ubuntu, mpich) Build for 6349654 (2023-05-09 16:45:36 UTC) PR tests (clang-10, ubuntu, mpich) Build for 7d27c8f (2023-06-14 08:17:33 UTC) PR tests (gcc-11, ubuntu, mpich, trace runtime, coverage) Build for 7d27c8f (2023-06-14 08:17:33 UTC) PR tests (intel icpc, ubuntu, mpich) Build for 7d27c8f (2023-06-14 08:17:33 UTC) PR tests (nvidia cuda 11.2, gcc-9, ubuntu, mpich) Build for 7d27c8f (2023-06-14 08:17:33 UTC) |
JacobDomagala
force-pushed
the
2036-allow-for-multiple-perf-test-per-file
branch
from
72c4c5b to
4148a6c
Compare
JacobDomagala
force-pushed
the
2036-allow-for-multiple-perf-test-per-file
branch
from
4148a6c to
05fdf4e
Compare
JacobDomagala
force-pushed
the
2036-allow-for-multiple-perf-test-per-file
branch
from
05fdf4e to
80a2656
Compare
JacobDomagala
requested review from
PhilMiller,
stmcgovern,
lifflander,
cz4rs,
nmm0,
thearusable and
nlslatt
JacobDomagala
force-pushed
the
2036-allow-for-multiple-perf-test-per-file
branch
2 times, most recently
from
bbea007 to
6349654
Compare
JacobDomagala
force-pushed
the
2036-allow-for-multiple-perf-test-per-file
branch
from
6349654 to
46d0117
Compare
| @@ -264,7 +264,7 @@ foreach(PERF_TEST ${PROJECT_PERF_TESTS}) | |||
| PROPERTIES | |||
| PROCESSORS ${PERF_TEST_NUMPROC} | |||
| RUN_SERIAL TRUE # do not run in parallel with any other tests | |||
| TIMEOUT 300 | |||
| TIMEOUT 500 | |||
There was a problem hiding this comment.
Increased the timeout, as we now run multiple tests inside single test file
There was a problem hiding this comment.
@JacobDomagala @lifflander I'm trying to understand what the collection_local_send.cc perf tests actually do. Is it true that only rank 0 runs the timed perf test, and only does a send to collection element 0, which is assumed to be local to rank 0 but not verified? It seems like some stuff could be simplified, like (a) consistently using my_node_ instead of theContext()->getNode(), (b) also only pre-allocating on rank 0, and (c) using preallocate_ to conditionally pre-allocate based on what happened in initialiaze instead of having the separate perfMakeRunnable and perfMakeRunnablePreAllocate calls.
There was a problem hiding this comment.
#2155 should address those issues
JacobDomagala
force-pushed
the
2036-allow-for-multiple-perf-test-per-file
branch
2 times, most recently
from
cc0807e to
3d416a5
Compare
JacobDomagala
force-pushed
the
2036-allow-for-multiple-perf-test-per-file
branch
from
3d416a5 to
1e98754
Compare
…by using updated macros in a single file
JacobDomagala
force-pushed
the
2036-allow-for-multiple-perf-test-per-file
branch
from
1e98754 to
7d27c8f
Compare
Fixes #2036