Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2100: Disable unity builds for gcc 7/8 #2101

Merged
merged 2 commits into from
Mar 14, 2023
Merged

#2100: Disable unity builds for gcc 7/8 #2101

merged 2 commits into from
Mar 14, 2023

Conversation

PhilMiller
Copy link
Member

Closes: #2100

@PhilMiller PhilMiller requested a review from lifflander March 10, 2023 20:54
@github-actions
Copy link

github-actions bot commented Mar 10, 2023

Pipelines results

PR tests (clang-9, ubuntu, mpich)

Build for 5a15b29 (2023-03-13 16:50:30 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for 5a15b29 (2023-03-13 16:50:30 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for 5a15b29 (2023-03-13 16:50:30 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for 5a15b29 (2023-03-13 16:50:30 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for 5a15b29 (2023-03-13 16:50:30 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (clang-12, ubuntu, mpich)

Build for 5a15b29 (2023-03-13 16:50:30 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (clang-13, ubuntu, mpich)

Build for 5a15b29 (2023-03-13 16:50:30 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (clang-14, ubuntu, mpich)

Build for 5a15b29 (2023-03-13 16:50:30 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (gcc-11, ubuntu, mpich, json schema test)

Build for 5a15b29 (2023-03-13 16:50:30 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (gcc-12, ubuntu, mpich)

Build for 5a15b29 (2023-03-13 16:50:30 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for 5a15b29 (2023-03-13 16:50:30 UTC)

/vt/src/vt/runnable/runnable.h(248): warning: missing return statement at end of non-void function "vt::runnable::RunnableNew::runLambda(Callable &&, Args &&...) [with Callable=__nv_bool (NodeObj::*)(), Args=<NodeObj *>]"
          detected during:
            instantiation of "decltype(auto) vt::runnable::RunnableNew::runLambda(Callable &&, Args &&...) [with Callable=__nv_bool (NodeObj::*)(), Args=<NodeObj *>]" 
/vt/src/vt/runnable/make_runnable.h(282): here
            instantiation of "auto vt::runnable::RunnableMaker<MsgT>::runLambda(Callable &&, Args &&...) [with MsgT=vt::BaseMsgType, Callable=__nv_bool (NodeObj::*)(), Args=<NodeObj *>]" 
/vt/src/vt/objgroup/manager.impl.h(227): here
            instantiation of "auto vt::objgroup::ObjGroupManager::invoke<ObjT,f,Args...>(vt::objgroup::ObjGroupManager::ProxyElmType<ObjT>, Args &&...) [with ObjT=NodeObj, f=&NodeObj::isWorkFinished, Args=<>]" 
/vt/src/vt/objgroup/proxy/proxy_objgroup_elm.impl.h(93): here
            instantiation of "decltype(auto) vt::objgroup::proxy::ProxyElm<ObjT>::invoke<f,Args...>(Args &&...) const [with ObjT=NodeObj, f=&NodeObj::isWorkFinished, Args=<>]" 
/vt/examples/collection/jacobi1d_vt.cc(325): here

/vt/src/vt/runnable/runnable.h(248): warning: missing return statement at end of non-void function "vt::runnable::RunnableNew::runLambda(Callable &&, Args &&...) [with Callable=bool (NodeObj::*)(), Args=<NodeObj *>]"
          detected during:
            instantiation of "decltype(auto) vt::runnable::RunnableNew::runLambda(Callable &&, Args &&...) [with Callable=bool (NodeObj::*)(), Args=<NodeObj *>]" 
/vt/src/vt/runnable/make_runnable.h(282): here
            instantiation of "auto vt::runnable::RunnableMaker<MsgT>::runLambda(Callable &&, Args &&...) [with MsgT=vt::BaseMsgType, Callable=bool (NodeObj::*)(), Args=<NodeObj *>]" 
/vt/src/vt/objgroup/manager.impl.h(227): here
            instantiation of "auto vt::objgroup::ObjGroupManager::invoke<ObjT,f,Args...>(vt::objgroup::ObjGroupManager::ProxyElmType<ObjT>, Args &&...) [with ObjT=NodeObj, f=&NodeObj::isWorkFinished, Args=<>]" 
/vt/src/vt/objgroup/proxy/proxy_objgroup_elm.impl.h(93): here
            instantiation of "decltype(auto) vt::objgroup::proxy::ProxyElm<ObjT>::invoke<f,Args...>(Args &&...) const [with ObjT=NodeObj, f=&NodeObj::isWorkFinished, Args=<>]" 
/vt/examples/collection/jacobi1d_vt.cc(325): here

/vt/src/vt/runnable/runnable.h(248): warning: missing return statement at end of non-void function "vt::runnable::RunnableNew::runLambda(Callable &&, Args &&...) [with Callable=__nv_bool (NodeObj::*)(), Args=<NodeObj *>]"
          detected during:
            instantiation of "decltype(auto) vt::runnable::RunnableNew::runLambda(Callable &&, Args &&...) [with Callable=__nv_bool (NodeObj::*)(), Args=<NodeObj *>]" 
/vt/src/vt/runnable/make_runnable.h(282): here-=-=%0D%0A%0D%0A%0D%0A ==> And there is more. Read log. <==

Build log


PR tests (nvidia cuda 11.2, ubuntu, mpich)

Build for ( UTC)

/vt/src/vt/runnable/runnable.h(248): warning: missing return statement at end of non-void function "vt::runnable::RunnableNew::runLambda(Callable &&, Args &&...) [with Callable=__nv_bool (NodeObj::*)(), Args=<NodeObj *>]"
          detected during:
            instantiation of "decltype(auto) vt::runnable::RunnableNew::runLambda(Callable &&, Args &&...) [with Callable=__nv_bool (NodeObj::*)(), Args=<NodeObj *>]" 
/vt/src/vt/runnable/make_runnable.h(282): here
            instantiation of "auto vt::runnable::RunnableMaker<MsgT>::runLambda(Callable &&, Args &&...) [with MsgT=vt::BaseMsgType, Callable=__nv_bool (NodeObj::*)(), Args=<NodeObj *>]" 
/vt/src/vt/objgroup/manager.impl.h(227): here
            instantiation of "auto vt::objgroup::ObjGroupManager::invoke<ObjT,f,Args...>(vt::objgroup::ObjGroupManager::ProxyElmType<ObjT>, Args &&...) [with ObjT=NodeObj, f=&NodeObj::isWorkFinished, Args=<>]" 
/vt/src/vt/objgroup/proxy/proxy_objgroup_elm.impl.h(93): here
            instantiation of "decltype(auto) vt::objgroup::proxy::ProxyElm<ObjT>::invoke<f,Args...>(Args &&...) const [with ObjT=NodeObj, f=&NodeObj::isWorkFinished, Args=<>]" 
/vt/examples/collection/jacobi1d_vt.cc(325): here

/vt/src/vt/runnable/runnable.h(248): warning: missing return statement at end of non-void function "vt::runnable::RunnableNew::runLambda(Callable &&, Args &&...) [with Callable=bool (NodeObj::*)(), Args=<NodeObj *>]"
          detected during:
            instantiation of "decltype(auto) vt::runnable::RunnableNew::runLambda(Callable &&, Args &&...) [with Callable=bool (NodeObj::*)(), Args=<NodeObj *>]" 
/vt/src/vt/runnable/make_runnable.h(282): here
            instantiation of "auto vt::runnable::RunnableMaker<MsgT>::runLambda(Callable &&, Args &&...) [with MsgT=vt::BaseMsgType, Callable=bool (NodeObj::*)(), Args=<NodeObj *>]" 
/vt/src/vt/objgroup/manager.impl.h(227): here
            instantiation of "auto vt::objgroup::ObjGroupManager::invoke<ObjT,f,Args...>(vt::objgroup::ObjGroupManager::ProxyElmType<ObjT>, Args &&...) [with ObjT=NodeObj, f=&NodeObj::isWorkFinished, Args=<>]" 
/vt/src/vt/objgroup/proxy/proxy_objgroup_elm.impl.h(93): here
            instantiation of "decltype(auto) vt::objgroup::proxy::ProxyElm<ObjT>::invoke<f,Args...>(Args &&...) const [with ObjT=NodeObj, f=&NodeObj::isWorkFinished, Args=<>]" 
/vt/examples/collection/jacobi1d_vt.cc(325): here

/vt/src/vt/runnable/runnable.h(248): warning: missing return statement at end of non-void function "vt::runnable::RunnableNew::runLambda(Callable &&, Args &&...) [with Callable=__nv_bool (NodeObj::*)(), Args=<NodeObj *>]"
          detected during:
            instantiation of "decltype(auto) vt::runnable::RunnableNew::runLambda(Callable &&, Args &&...) [with Callable=__nv_bool (NodeObj::*)(), Args=<NodeObj *>]" 
/vt/src/vt/runnable/make_runnable.h(282): here-=-=%0D%0A%0D%0A%0D%0A ==> And there is more. Read log. <==

Build log


PR tests (clang-10, ubuntu, mpich)

Build for 5a15b29 (2023-03-13 16:50:30 UTC)

Compilation - successful

Testing - passed

Build log


PR tests (intel icpc, ubuntu, mpich)

Build for 5a15b29 (2023-03-13 16:50:30 UTC)

intel-cc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.
intel-cc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.
intel-cc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.
intel-cc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.
intel-cc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.
intel-cc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.
intel-cc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.
intel-cc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.
intel-cc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.-%0D%0A%0D%0A%0D%0A ==> And there is more. Read log. <==

Build log


PR tests (clang-11, ubuntu, mpich)

Build for 5a15b29 (2023-03-13 16:50:30 UTC)

Compilation - successful

Testing - passed

Build log


cz4rs
cz4rs previously requested changes Mar 13, 2023
Copy link
Contributor

@cz4rs cz4rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update the .yml files using generate-workflow.pl script:

./scripts/generate-workflow.pl ./scripts/azure-workflow-template.yml ./scripts/workflows-azure.ini

@cz4rs
Copy link
Contributor

cz4rs commented Mar 13, 2023

Note: we could also drop gcc-7 build and move its configuration (trace + code coverage) to some other build (for example clang-12 and clang-13 are using pure default settings).

@PhilMiller PhilMiller dismissed cz4rs’s stale review March 14, 2023 17:01

Stale - Jonathan regenerated the workflows

Copy link
Contributor

@cz4rs cz4rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lifflander lifflander merged commit 23ac286 into develop Mar 14, 2023
@PhilMiller PhilMiller deleted the 2100-gcc-ci-oom branch March 14, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable unity build for gcc 8 CI that hits OOM
3 participants