#2068: disable vtAssert test for Intel Classic #2112

cz4rs · 2023-03-21T18:12:21Z

fixes #2068

tests/unit/runtime/test_preconfig.nompi.cc

github-actions · 2023-03-21T18:36:42Z

Pipelines results

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for b0a44b7 (2023-03-22 17:31:22 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for b0a44b7 (2023-03-22 17:31:22 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for b0a44b7 (2023-03-22 17:31:22 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-9, ubuntu, mpich)

Build for b0a44b7 (2023-03-22 17:31:22 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for b0a44b7 (2023-03-22 17:31:22 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for b0a44b7 (2023-03-22 17:31:22 UTC)

/vt/src/vt/objgroup/proxy/proxy_objgroup_elm.impl.h(98): warning: missing return statement at end of non-void function "vt::objgroup::proxy::ProxyElm<ObjT>::send<fn,Args...>(Args &&...) const [with ObjT=NodeObj, fn=&NodeObj::perfMakeRunnable, Args=<>]"
          detected during instantiation of "vt::objgroup::proxy::ProxyElm<ObjT>::PendingSendType vt::objgroup::proxy::ProxyElm<ObjT>::send<fn,Args...>(Args &&...) const [with ObjT=NodeObj, fn=&NodeObj::perfMakeRunnable, Args=<>]" 
/vt/tests/perf/collection_local_send.cc(120): here

/vt/src/vt/vrt/collection/send/sendable.impl.h(156): warning: missing return statement at end of non-void function "vt::vrt::collection::Sendable<ColT, IndexT, BaseProxyT>::send<f,Args...>(Args &&...) const [with ColT=vt::tests::unit::comm::<unnamed>::MyCol, IndexT=vt::Index1D, BaseProxyT=vt::vrt::collection::elm_proxy::Chain2<vt::tests::unit::comm::<unnamed>::MyCol, vt::Index1D>, f=&vt::tests::unit::comm::<unnamed>::handler2, Args=<>]"
          detected during instantiation of "vt::messaging::PendingSend vt::vrt::collection::Sendable<ColT, IndexT, BaseProxyT>::send<f,Args...>(Args &&...) const [with ColT=vt::tests::unit::comm::<unnamed>::MyCol, IndexT=vt::Index1D, BaseProxyT=vt::vrt::collection::elm_proxy::Chain2<vt::tests::unit::comm::<unnamed>::MyCol, vt::Index1D>, f=&vt::tests::unit::comm::<unnamed>::handler2, Args=<>]" 
/vt/tests/unit/lb/test_lb_data_comm.cc(165): here

/vt/src/vt/vrt/collection/broadcast/broadcastable.impl.h(200): warning: missing return statement at end of non-void function "vt::vrt::collection::Broadcastable<ColT, IndexT, BaseProxyT>::broadcast<f,Args...>(Args &&...) const [with ColT=vt::tests::unit::bcast::bcast_col_::TestCol<int32_t>, IndexT=vt::tests::unit::TestIndex, BaseProxyT=vt::vrt::collection::col_proxy::Chain4<vt::tests::unit::bcast::bcast_col_::TestCol<int32_t>, vt::tests::unit::TestIndex>, f=&vt::tests::unit::bcast::BroadcastHandlers<vt::tests::unit::bcast::bcast_col_::TestCol<int32_t>, vt::tests::unit::bcast::bcast_col_::ColMsg<int32_t>, std::tuple<int32_t>>::handler, Args=<std::tuple<int32_t> &>]"
          detected during:
            instantiation of "vt::messaging::PendingSend vt::vrt::collection::Broadcastable<ColT, IndexT, BaseProxyT>::broadcast<f,Args...>(Args &&...) const [with ColT=vt::tests::unit::bcast::bcast_col_::TestCol<int32_t>, IndexT=vt::tests::unit::TestIndex, BaseProxyT=vt::vrt::collection::col_proxy::Chain4<vt::tests::unit::bcast::bcast_col_::TestCol<int32_t>, vt::tests::unit::TestIndex>, f=&vt::tests::unit::bcast::BroadcastHandlers<vt::tests::unit::bcast::bcast_col_::TestCol<int32_t>, vt::tests::unit::bcast::bcast_col_::ColMsg<int32_t>, std::tuple<int32_t>>::handler, Args=<std::tuple<int32_t> &>]" 
/vt/tests/unit/collection/test_broadcast.h(135): here
            instantiation of "void vt::tests::unit::bcast::test_broadcast_1<ColType>(const std::string &) [with ColType=vt::tests::unit::bcast%0D%0A%0D%0A%0D%0A ==> And there is more. Read log. <==

Build log

PR tests (clang-12, ubuntu, mpich)

Build for b0a44b7 (2023-03-22 17:31:22 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-11, ubuntu, mpich)

Build for b0a44b7 (2023-03-22 17:31:22 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-11, ubuntu, mpich, json schema test)

Build for b0a44b7 (2023-03-22 17:31:22 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-12, ubuntu, mpich)

Build for b0a44b7 (2023-03-22 17:31:22 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-13, ubuntu, mpich)

Build for b0a44b7 (2023-03-22 17:31:22 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-14, ubuntu, mpich)

Build for b0a44b7 (2023-03-22 17:31:22 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (nvidia cuda 11.2, ubuntu, mpich)

Build for ( UTC)

/vt/src/vt/objgroup/proxy/proxy_objgroup_elm.impl.h(98): warning: missing return statement at end of non-void function "vt::objgroup::proxy::ProxyElm<ObjT>::send<fn,Args...>(Args &&...) const [with ObjT=NodeObj, fn=&NodeObj::perfMakeRunnable, Args=<>]"
          detected during instantiation of "vt::objgroup::proxy::ProxyElm<ObjT>::PendingSendType vt::objgroup::proxy::ProxyElm<ObjT>::send<fn,Args...>(Args &&...) const [with ObjT=NodeObj, fn=&NodeObj::perfMakeRunnable, Args=<>]" 
/vt/tests/perf/collection_local_send.cc(120): here

/vt/src/vt/vrt/collection/send/sendable.impl.h(156): warning: missing return statement at end of non-void function "vt::vrt::collection::Sendable<ColT, IndexT, BaseProxyT>::send<f,Args...>(Args &&...) const [with ColT=vt::tests::unit::comm::<unnamed>::MyCol, IndexT=vt::Index1D, BaseProxyT=vt::vrt::collection::elm_proxy::Chain2<vt::tests::unit::comm::<unnamed>::MyCol, vt::Index1D>, f=&vt::tests::unit::comm::<unnamed>::handler2, Args=<>]"
          detected during instantiation of "vt::messaging::PendingSend vt::vrt::collection::Sendable<ColT, IndexT, BaseProxyT>::send<f,Args...>(Args &&...) const [with ColT=vt::tests::unit::comm::<unnamed>::MyCol, IndexT=vt::Index1D, BaseProxyT=vt::vrt::collection::elm_proxy::Chain2<vt::tests::unit::comm::<unnamed>::MyCol, vt::Index1D>, f=&vt::tests::unit::comm::<unnamed>::handler2, Args=<>]" 
/vt/tests/unit/lb/test_lb_data_comm.cc(165): here

/vt/src/vt/vrt/collection/broadcast/broadcastable.impl.h(200): warning: missing return statement at end of non-void function "vt::vrt::collection::Broadcastable<ColT, IndexT, BaseProxyT>::broadcast<f,Args...>(Args &&...) const [with ColT=vt::tests::unit::bcast::bcast_col_::TestCol<int32_t>, IndexT=vt::tests::unit::TestIndex, BaseProxyT=vt::vrt::collection::col_proxy::Chain4<vt::tests::unit::bcast::bcast_col_::TestCol<int32_t>, vt::tests::unit::TestIndex>, f=&vt::tests::unit::bcast::BroadcastHandlers<vt::tests::unit::bcast::bcast_col_::TestCol<int32_t>, vt::tests::unit::bcast::bcast_col_::ColMsg<int32_t>, std::tuple<int32_t>>::handler, Args=<std::tuple<int32_t> &>]"
          detected during:
            instantiation of "vt::messaging::PendingSend vt::vrt::collection::Broadcastable<ColT, IndexT, BaseProxyT>::broadcast<f,Args...>(Args &&...) const [with ColT=vt::tests::unit::bcast::bcast_col_::TestCol<int32_t>, IndexT=vt::tests::unit::TestIndex, BaseProxyT=vt::vrt::collection::col_proxy::Chain4<vt::tests::unit::bcast::bcast_col_::TestCol<int32_t>, vt::tests::unit::TestIndex>, f=&vt::tests::unit::bcast::BroadcastHandlers<vt::tests::unit::bcast::bcast_col_::TestCol<int32_t>, vt::tests::unit::bcast::bcast_col_::ColMsg<int32_t>, std::tuple<int32_t>>::handler, Args=<std::tuple<int32_t> &>]" 
/vt/tests/unit/collection/test_broadcast.h(135): here
            instantiation of "void vt::tests::unit::bcast::test_broadcast_1<ColType>(const std::string &) [with ColType=vt::tests::unit::bcast%0D%0A%0D%0A%0D%0A ==> And there is more. Read log. <==

Build log

PR tests (clang-10, ubuntu, mpich)

Build for b0a44b7 (2023-03-22 17:31:22 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (intel icpc, ubuntu, mpich)

Build for b0a44b7 (2023-03-22 17:31:22 UTC)

icpc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.
icpc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.
intel-cc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.
intel-cc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.
intel-cc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.
intel-cc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.
intel-cc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.
intel-cc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.
intel-cc: remark #10441: The Intel(R) C++ Compiler Classic (ICC) is deprecated and will be removed from product release in the second half of 2023. The Intel(R) oneAPI DPC++/C++ Compiler (ICX) is the recommended compiler moving forward. Please transition to use this compiler. Use '-diag-disable=10441' to disable this message.
in%0D%0A%0D%0A%0D%0A ==> And there is more. Read log. <==

Build log

PhilMiller · 2023-03-21T21:27:06Z

tests/unit/runtime/test_preconfig.nompi.cc

@@ -51,7 +51,7 @@ namespace vt { namespace tests { namespace unit {

 struct TestPreconfig : TestHarness { };

-#if not vt_check_enabled(production_build)
+#if not vt_check_enabled(production_build) and not defined(__INTEL_COMPILER)


Following Kokkos practice, it's maybe preferable to conditionalize inside the test, and call GTEST_SKIP in the case where the test won't be run.

2023-03-22T18:05:03.4641692Z Start 387: vt:TestPreconfig.test_vt_assert_no_mpi 2023-03-22T18:05:03.4745283Z 387/487 Test #387: vt:TestPreconfig.test_vt_assert_no_mpi .............................................***Skipped 0.01 sec

Test segfaults when built with icpc 2021.8.0.

nlslatt

Looks good

cz4rs commented Mar 21, 2023

View reviewed changes

tests/unit/runtime/test_preconfig.nompi.cc Outdated Show resolved Hide resolved

cz4rs force-pushed the 2068-disable-assertion-test-intel-classic branch from 62ddaa4 to 390f477 Compare March 21, 2023 18:15

cz4rs requested review from JacobDomagala, lifflander, nlslatt, nmm0, PhilMiller, stmcgovern and thearusable March 21, 2023 18:29

PhilMiller reviewed Mar 21, 2023

View reviewed changes

#2068: skip vtAssert test for Intel Classic compiler

b0a44b7

Test segfaults when built with icpc 2021.8.0.

cz4rs force-pushed the 2068-disable-assertion-test-intel-classic branch from 390f477 to b0a44b7 Compare March 22, 2023 17:31

nlslatt approved these changes Mar 22, 2023

View reviewed changes

JacobDomagala approved these changes Mar 22, 2023

View reviewed changes

cz4rs requested a review from PhilMiller March 22, 2023 19:09

PhilMiller approved these changes Mar 22, 2023

View reviewed changes

PhilMiller merged commit e87e1b0 into develop Mar 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#2068: disable vtAssert test for Intel Classic #2112

#2068: disable vtAssert test for Intel Classic #2112

cz4rs commented Mar 21, 2023

github-actions bot commented Mar 21, 2023 •

edited

Loading

PhilMiller Mar 21, 2023

cz4rs Mar 22, 2023

nlslatt left a comment

#2068: disable vtAssert test for Intel Classic #2112

#2068: disable vtAssert test for Intel Classic #2112

Conversation

cz4rs commented Mar 21, 2023

github-actions bot commented Mar 21, 2023 • edited Loading

Pipelines results

PhilMiller Mar 21, 2023

Choose a reason for hiding this comment

cz4rs Mar 22, 2023

Choose a reason for hiding this comment

nlslatt left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 21, 2023 •

edited

Loading