Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2122: Silence icpc deprecation warning #2129

Merged
merged 3 commits into from
May 9, 2023
Merged

#2122: Silence icpc deprecation warning #2129

merged 3 commits into from
May 9, 2023

Conversation

JacobDomagala
Copy link
Contributor

Fixes #2122

@github-actions
Copy link

github-actions bot commented Apr 8, 2023 •
edited
Loading

Pipelines results

PR tests (clang-9, ubuntu, mpich)

Build for a5df9ff (2023-05-08 18:25:48 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-9, ubuntu, mpich, zoltan, json schema test)

Build for a5df9ff (2023-05-08 18:25:48 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-11, ubuntu, mpich)

Build for a5df9ff (2023-05-08 18:25:48 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for a5df9ff (2023-05-08 18:25:48 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for a5df9ff (2023-05-08 18:25:48 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-12, ubuntu, mpich)

Build for a5df9ff (2023-05-08 18:25:48 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-13, ubuntu, mpich)

Build for a5df9ff (2023-05-08 18:25:48 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-14, ubuntu, mpich)

Build for a5df9ff (2023-05-08 18:25:48 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-12, ubuntu, mpich)

Build for a5df9ff (2023-05-08 18:25:48 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for fa1d9c4 (2023-04-08 13:28:02 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (nvidia cuda 11.2, ubuntu, mpich)

Build for a5df9ff (2023-05-08 18:25:48 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-10, ubuntu, mpich)

Build for a5df9ff (2023-05-08 18:25:48 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-11, ubuntu, mpich, trace runtime, coverage)

Build for a5df9ff (2023-05-08 18:25:48 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (intel icpc, ubuntu, mpich)

Build for a5df9ff (2023-05-08 18:25:48 UTC)

Compilation - successful

Testing - passed

Build log

JacobDomagala
JacobDomagala commented Apr 8, 2023
View reviewed changes
cmake/load_bundled_libraries.cmake
@@ -41,9 +41,12 @@ set(BROTLI_DISABLE_TESTS ON)
# we need to disable bundled mode so it will install properly
set(BROTLI_BUNDLED_MODE OFF)
set(BROTLI_BUILD_PORTABLE ON)
set(BROTLI_LIBRARY brotlicommon-static brotlienc-static brotlidec-static)
set(BROTLI_BUILD_SHARED_LIBS OFF)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vt is only using static libs. This shouldn't affect anyone, I think.

PhilMiller
PhilMiller reviewed Apr 18, 2023
View reviewed changes
cmake-modules/SetCXXCompilerFlags.cmake Outdated
@@ -11,6 +11,12 @@ function(set_darma_compiler_flags vt_target)
endif ()
elseif (CMAKE_CXX_COMPILER_ID STREQUAL IntelLLVM AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL 2021.3.0)
list(APPEND TARGET_PRIVATE_CXX_FLAGS -fhonor-infinites -fhonor-nans)
elseif (${CMAKE_CXX_COMPILER_ID} MATCHES "Intel")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the be MATCHES or STREQUAL? Will we end up adding this flag for icpx?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you resolve this @JacobDomagala?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to STREQUAL

@PhilMiller
Copy link
Member

Why are the Brotli build changes part of this PR?

lifflander
lifflander approved these changes May 3, 2023
View reviewed changes
Copy link
Collaborator

@lifflander lifflander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved once Phil's comment is addressed.

@JacobDomagala JacobDomagala force-pushed the 2122-silence-icpc-warning branch from fa1d9c4 to 932cf87 Compare May 8, 2023 15:58
@JacobDomagala
Copy link
Contributor Author

Why are the Brotli build changes part of this PR?

Brotli builds static and shared libs and both of them generate icpc deprecation warnings. To fix that I disabled generation of shared libs (we don't need them since vt is only using static ones).

@JacobDomagala JacobDomagala force-pushed the 2122-silence-icpc-warning branch from 932cf87 to a5df9ff Compare May 8, 2023 18:25
@nmm0 nmm0 mentioned this pull request May 9, 2023
Open
@nlslatt nlslatt merged commit 070ea11 into develop May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilMiller PhilMiller PhilMiller left review comments

@nlslatt nlslatt nlslatt approved these changes

@lifflander lifflander lifflander approved these changes

@stmcgovern stmcgovern Awaiting requested review from stmcgovern

@cz4rs cz4rs Awaiting requested review from cz4rs

@nmm0 nmm0 Awaiting requested review from nmm0

@thearusable thearusable Awaiting requested review from thearusable

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add -diag-disable=10441 to CMAKE_CXX_FLAGS for icpc build
4 participants
@JacobDomagala @PhilMiller @lifflander @nlslatt