#2380: Add task measurements using linux perf #2381

pierrepebay · 2024-12-13T12:24:31Z

This contains the work done in #2304 with only the Linux Perf component.

github-actions · 2024-12-13T13:29:45Z

Pipelines results

PR tests (clang-13, alpine, mpich)

Build for b533dda (2024-12-13 13:01:57 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for b533dda (2024-12-13 13:01:57 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-9, ubuntu, mpich)

Build for b533dda (2024-12-13 13:01:57 UTC)



The following tests FAILED:
  643 - vt:TestPreconfig.test_vt_assert_no_mpi (SEGFAULT)
  647 - vt:TestCliArguments.test_vt_assert_proc_1 (Failed)
  649 - vt:TestCliArguments.test_vt_assert_proc_2 (Failed)

Build log

PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for b533dda (2024-12-13 13:01:57 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-12, ubuntu, mpich)

Build for b533dda (2024-12-13 13:01:57 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-13, ubuntu, mpich)

Build for b533dda (2024-12-13 13:01:57 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-14, ubuntu, mpich, verbose)

Build for b533dda (2024-12-13 13:01:57 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-11, ubuntu, mpich)

Build for b533dda (2024-12-13 13:01:57 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (clang-10, ubuntu, mpich)

Build for b533dda (2024-12-13 13:01:57 UTC)



The following tests FAILED:
  940 - vt:TestPreconfig.test_vt_assert_no_mpi (Failed)
  944 - vt:TestCliArguments.test_vt_assert_proc_1 (Failed)
  946 - vt:TestCliArguments.test_vt_assert_proc_2 (Failed)
  948 - vt:TestCliArguments.test_vt_assert_proc_4 (Failed)

Build log

PR tests (gcc-11, ubuntu, mpich, trace runtime, coverage)

Build for b533dda (2024-12-13 13:01:57 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (intel icpx, ubuntu, mpich, verbose)

Build for b533dda (2024-12-13 13:01:57 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (nvidia cuda 12.2.0, gcc-9, ubuntu, mpich, verbose)

Build for b533dda (2024-12-13 13:01:57 UTC)

/vt/lib/CLI/CLI/CLI11.hpp(1029): warning #2361-D: invalid narrowing conversion from "double" to "unsigned long"
          TT { std::declval<CC>() }
               ^
          detected during:
            instantiation of "vt::CLI::detail::is_direct_constructible<T, C>::test [with T=std::vector<std::string, std::allocator<std::string>>, C=double]" based on template arguments <std::vector<std::string, std::allocator<std::string>>, double> at line 1041
            instantiation of class "vt::CLI::detail::is_direct_constructible<T, C> [with T=std::vector<std::string, std::allocator<std::string>>, C=double]" at line 5005
            instantiation of "void vt::CLI::Option::results(T &) const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 5034
            instantiation of "T vt::CLI::Option::as<T>() const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 7315

Remark: The warnings can be suppressed with "-diag-suppress <warning-number>"

/vt/lib/CLI/CLI/CLI11.hpp(1029): warning #2361-D: invalid narrowing conversion from "int" to "unsigned long"
          TT { std::declval<CC>() }
               ^
          detected during:
            instantiation of "vt::CLI::detail::is_direct_constructible<T, C>::test [with T=std::vector<std::string, std::allocator<std::string>>, C=int]" based on template arguments <std::vector<std::string, std::allocator<std::string>>, int> at line 1041
            instantiation of class "vt::CLI::detail::is_direct_constructible<T, C> [with T=std::vector<std::string, std::allocator<std::string>>, C=int]" at line 5005
            instantiation of "void vt::CLI::Option::results(T &) const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 5034
            instantiation of "T vt::CLI::Option::as<T>() const [with T=std::vector<std::string, std::allocator<std::string>>]" at line 7315

Testing - passed

Build log

PR tests (gcc-12, ubuntu, mpich, verbose, kokkos)

Build for b533dda (2024-12-13 13:01:57 UTC)

Compilation - successful

Testing - passed

Build log

PR tests (nvidia cuda 11.2, gcc-9, ubuntu, mpich)

Build for b533dda (2024-12-13 13:01:57 UTC)

/vt/src/vt/pipe/pipe_manager.impl.h(135): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>]"
          detected during:
            instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>]" 
/vt/src/vt/objgroup/proxy/proxy_objgroup.impl.h(221): here
            instantiation of "vt::objgroup::proxy::Proxy<ObjT>::PendingSendType vt::objgroup::proxy::Proxy<ObjT>::reduce<f,Op,Target,Args...>(Target, Args &&...) const [with ObjT=vt::vrt::collection::lb::GreedyLB, f=&vt::vrt::collection::lb::GreedyLB::collectHandler, Op=vt::collective::PlusOp, Target=vt::objgroup::proxy::ProxyElm<vt::vrt::collection::lb::GreedyLB>, Args=<vt::vrt::collection::lb::GreedyPayload>]" 
/vt/src/vt/vrt/collection/balance/greedylb/greedylb.cc(222): here

/vt/src/vt/pipe/pipe_manager.impl.h(135): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]" 
/vt/examples/callback/callback.cc(147): here

/vt/src/vt/pipe/pipe_manager.impl.h(135): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]" 
/vt/examples/callback/callback.cc(153): here

/vt/src/vt/pipe/pipe_manager.impl.h(135): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&MyObj::handler, Target=vt::objgroup::proxy::ProxyElm<MyObj>]" 
/vt/examples/callback/callback.cc(147): here

/vt/src/vt/pipe/pipe_manager.impl.h(135): warning: missing return statement at end of non-void function "vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]"
          detected during instantiation of "auto vt::pipe::PipeManager::makeSend<f,Target>(Target) [with f=&colHan, Target=vt::vrt::collection::VrtElmProxy<MyCol, vt::Index1D>]" 
/vt/examples/callback/callback.cc(153%0D%0A%0D%0A%0D%0A ==> And there is more. Read log. <==

Build log

PR tests (intel icpc, ubuntu, mpich)

Build for b533dda (2024-12-13 13:01:57 UTC)

remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhibited by limit max-total-size 
remark #11076: To get full report use -qopt-report=4 -qopt-report-phase ipo
remark #11074: Inlining inhibited by limit max-size 
remark #11074: Inlining inhi%0D%0A%0D%0A%0D%0A ==> And there is more. Read log. <==

Build log

lifflander

Looks good overall. A few minor improvements requested

lifflander · 2024-12-17T20:22:53Z

src/vt/metrics/perf_data.cc

+    }
+  }
+
+  for (const auto &event_name : event_names_) {


Suggested change

for (const auto &event_name : event_names_) {

for (auto const& event_name : event_names_) {

lifflander · 2024-12-17T20:23:05Z

src/vt/metrics/perf_data.cc

+  }
+
+  // Initialize perf events once and store file descriptors
+  for (const auto &event_name : event_names_) {


Suggested change

for (const auto &event_name : event_names_) {

for (auto const& event_name : event_names_) {

lifflander · 2024-12-17T20:24:11Z

src/vt/metrics/perf_data.h

+   * Cleans up resources, closing file descriptors associated with performance
+   * counters.
+   */
+  ~PerfData();


Need a virtual destructor here.

pierrepebay added 6 commits December 13, 2024 12:18

#2380: metrics: Add build configuration option

9bfd088

#2380: metrics: Add perf data component

3ab3a46

#2380: examples: Add perf data example

36e9b3f

#2380: tests: Add perf data test

3955962

#2380: ci: Add perf data workflows

ed2a61d

#2380: examples: Fix perf data example

33c3211

pierrepebay requested review from lifflander, cz4rs and nlslatt December 13, 2024 12:24

pierrepebay self-assigned this Dec 13, 2024

pierrepebay linked an issue Dec 13, 2024 that may be closed by this pull request

Add task measurements using Linux perf #2380

Open

pierrepebay changed the title ~~Add task measurements using linux perf~~ #2380: Add task measurements using linux perf Dec 13, 2024

pierrepebay added 2 commits December 13, 2024 13:32

#2380: metrics: Fix include guards

967e20f

#2380: tests: Fix metrics include guard

b533dda

lifflander requested changes Dec 17, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#2380: Add task measurements using linux perf #2381

#2380: Add task measurements using linux perf #2381

pierrepebay commented Dec 13, 2024

github-actions bot commented Dec 13, 2024 •

edited

Loading

lifflander left a comment

lifflander Dec 17, 2024

lifflander Dec 17, 2024

lifflander Dec 17, 2024

	for (const auto &event_name : event_names_) {
	for (auto const& event_name : event_names_) {

#2380: Add task measurements using linux perf #2381

Are you sure you want to change the base?

#2380: Add task measurements using linux perf #2381

Conversation

pierrepebay commented Dec 13, 2024

github-actions bot commented Dec 13, 2024 • edited Loading

Pipelines results

lifflander left a comment

Choose a reason for hiding this comment

lifflander Dec 17, 2024

Choose a reason for hiding this comment

lifflander Dec 17, 2024

Choose a reason for hiding this comment

lifflander Dec 17, 2024

Choose a reason for hiding this comment

github-actions bot commented Dec 13, 2024 •

edited

Loading