-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#708: Pass subphase timings through to ProcStats, and write them out #826
Conversation
I think we should close #708 with this, since further work on models and/or strategies that make effective use of the subphase timing data is a pretty open-ended project. |
@ppebay Have a look at the format in which I'm writing out the subphase times. Will that pose a problem for the analysis tools? |
@PhilMiller What happened here? Why is MPI intercept code on this branch? Can you write a Doxygen comment documenting the new format (and current one also)? |
0d55fab
to
44ff190
Compare
Rebased to clear up the integration issues. Wrote up a full description of the stats file output in the comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
This seems to be failing Travis CI sometimes |
Codecov Report
@@ Coverage Diff @@
## develop #826 +/- ##
===========================================
+ Coverage 80.49% 80.50% +0.01%
===========================================
Files 353 352 -1
Lines 11207 11188 -19
===========================================
- Hits 9021 9007 -14
+ Misses 2186 2181 -5
|
70b3460
to
48267cf
Compare
48267cf
to
a822228
Compare
…gratable base instead
a822228
to
d726e59
Compare
Fixes: #708