Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#708: Pass subphase timings through to ProcStats, and write them out #826

Merged
merged 7 commits into from
Jun 10, 2020

Conversation

PhilMiller
Copy link
Member

@PhilMiller PhilMiller commented Jun 1, 2020

Fixes: #708

@PhilMiller PhilMiller requested a review from lifflander June 1, 2020 20:10
@PhilMiller
Copy link
Member Author

I think we should close #708 with this, since further work on models and/or strategies that make effective use of the subphase timing data is a pretty open-ended project.

@PhilMiller PhilMiller requested a review from ppebay June 2, 2020 19:00
@PhilMiller
Copy link
Member Author

@ppebay Have a look at the format in which I'm writing out the subphase times. Will that pose a problem for the analysis tools?

@lifflander
Copy link
Collaborator

@PhilMiller What happened here? Why is MPI intercept code on this branch?

Can you write a Doxygen comment documenting the new format (and current one also)?

@PhilMiller PhilMiller force-pushed the 708-vector-lb-stats branch from 0d55fab to 44ff190 Compare June 9, 2020 00:09
@PhilMiller
Copy link
Member Author

Rebased to clear up the integration issues.

Wrote up a full description of the stats file output in the comments.

Copy link
Collaborator

@lifflander lifflander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@lifflander
Copy link
Collaborator

This seems to be failing Travis CI sometimes

@codecov
Copy link

codecov bot commented Jun 9, 2020

Codecov Report

Merging #826 into develop will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #826      +/-   ##
===========================================
+ Coverage    80.49%   80.50%   +0.01%     
===========================================
  Files          353      352       -1     
  Lines        11207    11188      -19     
===========================================
- Hits          9021     9007      -14     
+ Misses        2186     2181       -5     
Impacted Files Coverage Δ
src/vt/vrt/collection/types/migratable.h 50.00% <ø> (ø)
src/vt/vrt/collection/balance/elm_stats.impl.h 92.68% <100.00%> (+0.18%) ⬆️
tests/unit/atomic/test_atomic.cc 100.00% <0.00%> (+1.31%) ⬆️

@PhilMiller PhilMiller force-pushed the 708-vector-lb-stats branch from 70b3460 to 48267cf Compare June 9, 2020 19:59
@lifflander lifflander force-pushed the 708-vector-lb-stats branch from 48267cf to a822228 Compare June 10, 2020 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Balance workloads within synchronized subphases (vector loads rather than scalar)
2 participants