Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

913 Split tests into "basic" and "extended" categories #924

Merged
merged 8 commits into from
Jul 15, 2020

Conversation

lifflander
Copy link
Collaborator

Fixes #913

  • Any test that ends in *.extended.cc will now be considered an extended test
  • The cmake option vt_build_extended_tests=1 can be used to control this (default ON)
  • The variable is pushed up to docker-compose.yml and the docker files
  • The Intel GitHub workflow disables extending testing when the workflow is running on a pull request (so merges to develop will run the full, extended testing

@codecov
Copy link

codecov bot commented Jul 14, 2020

Codecov Report

Merging #924 into develop will increase coverage by 1.69%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #924      +/-   ##
===========================================
+ Coverage    80.66%   82.36%   +1.69%     
===========================================
  Files          355      354       -1     
  Lines        11184    10922     -262     
===========================================
- Hits          9022     8996      -26     
+ Misses        2162     1926     -236     
Impacted Files Coverage Δ
tests/unit/collection/test_checkpoint.extended.cc 100.00% <ø> (ø)
.../unit/collection/test_collection_group.extended.cc 100.00% <ø> (ø)
tests/unit/collection/test_index_types.extended.cc 22.72% <ø> (ø)
tests/unit/collection/test_insert.extended.cc 100.00% <ø> (ø)
tests/unit/collection/test_lb_lite.extended.cc 94.20% <ø> (ø)
tests/unit/collectives/test_collectives_reduce.cc 100.00% <ø> (ø)
...t/collectives/test_collectives_scatter.extended.cc 100.00% <ø> (ø)
tests/unit/location/test_hops.extended.cc 92.30% <ø> (ø)
...it/pipe/test_callback_bcast_collection.extended.cc 96.05% <ø> (ø)
...nit/pipe/test_callback_send_collection.extended.cc 97.70% <ø> (ø)
... and 23 more

@lifflander
Copy link
Collaborator Author

@PhilMiller @pnstickne Please review

@lifflander
Copy link
Collaborator Author

Note that with this change, Intel 18.03 ran in 32 minutes!

@lifflander
Copy link
Collaborator Author

Crap, forgot to update the docs with this... need to do before merging

Copy link
Collaborator Author

Codacy Here is an overview of what got changed by this pull request:

Clones added
============
- tests/unit/rdma/test_rdma_static_sub_handle.extended.cc  22
- tests/unit/context/context_vrtmessage_test.extended.cc  1
- tests/unit/collection/test_construct_idx_snd.extended.cc  4
- tests/unit/collection/test_lb_lite.extended.cc  1
- tests/unit/scheduler/test_scheduler_progress.extended.cc  4
- tests/unit/sequencer/test_sequencer.extended.cc  2
- tests/unit/pipe/test_callback_send_collection.extended.cc  11
- tests/unit/collection/test_broadcast.h  5
- tests/unit/rdma/test_rdma_collection_handle.extended.cc  2
- tests/unit/sequencer/test_sequencer_vrt.extended.cc  5
- tests/unit/collectives/test_collectives_reduce.h  1
- tests/unit/context/context_vrtmanager_test.extended.cc  1
- tests/unit/rdma/test_rdma_handle.h  20
- tests/unit/scheduler/test_scheduler_priorities.extended.cc  7
- tests/unit/sequencer/test_sequencer_nested.extended.cc  5
- tests/unit/collection/test_send.h  9
- tests/unit/sequencer/test_sequencer_parallel.extended.cc  4
- tests/unit/serialization/test_serialize_messenger_virtual.extended.cc  1
- tests/unit/collection/test_insert.extended.cc  13
- tests/unit/collectives/test_collectives_reduce.extended.cc  3
- tests/unit/pipe/test_callback_bcast_collection.extended.cc  12
- tests/unit/collection/test_construct_idx_fst.extended.cc  4
- tests/unit/collection/test_construct_no_idx.extended.cc  5
         

Clones removed
==============
+ tests/unit/collection/test_broadcast.cc  -6
+ tests/unit/rdma/test_rdma_handle.cc  -22
+ tests/unit/collection/test_send.cc  -10
+ tests/unit/collectives/test_collectives_reduce.cc  -3
         

See the complete overview on Codacy

@lifflander lifflander merged commit 74c5d00 into develop Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split tests into basic and extended to reduce CI times
2 participants