Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model comparisons MIRA #5777

Merged
merged 52 commits into from
Dec 17, 2024
Merged

Model comparisons MIRA #5777

merged 52 commits into from
Dec 17, 2024

Conversation

YohannParis
Copy link
Member

@YohannParis YohannParis commented Dec 6, 2024 •
edited
Loading

Description

Implementation of the new MIRA comparison of model concepts

  • Adding controller to fetch the MIRA comparison
  • Created the SYNC task in mira-taskrunner
  • Add the call to the endpoint to the services/concept.ts
  • Display the result in the model-comparison operator
  • Display the graph images properly
Monosnap.screencast.2024-12-17.12-14-25.mp4

YohannParis and others added 27 commits December 6, 2024 07:13
@YohannParis
Update concept.ts
1cc9d6c
@YohannParis
Add Dataframe handling
4024296
@YohannParis
return images as base64
3e7fe18
@YohannParis
rename file
5e10d94
@YohannParis
Update model_comparison.py
badd1bf
@mwdchang
fix task setup
40b1939
@YohannParis
add fastapi
83c3914
@YohannParis
fetch the results from the miracompare model
ea5638d
@YohannParis
Update concept.ts
25d60b2
@YohannParis
second pass
95152a7
@YohannParis
third pass
cf09969
@YohannParis
remove seeing the ENV
89290f3
@YohannParis
better logs
b424b87
@YohannParis
final update, it works now
1e837aa
@YohannParis
clean and use apt not apt-get
9000cfe
@YohannParis
to have gcc we removed slim version
47b4db3
@YohannParis
Merge branch 'main' into model-comparisons-mira
994f775
@YohannParis
Merge branch 'main' into model-comparisons-mira
27921a6
@YohannParis
Update Dockerfile
336f833
@YohannParis
fixed call to backend
2bb6c50
@YohannParis
Add type to notifiation
ddca418
@github-actions
chore: lint types
a2932df
@YohannParis
Update tera-model-comparison-drilldown.vue
4972f39
@YohannParis
Update Dockerfile
cfff89b
@YohannParis
Update Dockerfile
9835475
@YohannParis
add papaparse to parse CSV
8b283bf
@YohannParis
improve tag names
7a5c28c
@YohannParis YohannParis marked this pull request as ready for review December 17, 2024 17:15
@YohannParis YohannParis assigned blanchco and asylves1 and unassigned mwdchang Dec 17, 2024
mwdchang
mwdchang approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@mwdchang mwdchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test - some small comments but code generally looks fine.

@YohannParis YohannParis merged commit 6a34ac8 into main Dec 17, 2024
10 checks passed
@YohannParis YohannParis deleted the model-comparisons-mira branch December 17, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvince2 dvince2 dvince2 approved these changes

@mwdchang mwdchang mwdchang approved these changes

@dgauldie dgauldie Awaiting requested review from dgauldie dgauldie is a code owner

@jryu01 jryu01 Awaiting requested review from jryu01 jryu01 is a code owner

@Tom-Szendrey Tom-Szendrey Awaiting requested review from Tom-Szendrey Tom-Szendrey is a code owner

@shawnyama shawnyama Awaiting requested review from shawnyama shawnyama is a code owner

@blanchco blanchco Awaiting requested review from blanchco blanchco is a code owner

@asylves1 asylves1 Awaiting requested review from asylves1 asylves1 is a code owner

@mloppie mloppie Awaiting requested review from mloppie mloppie is a code owner

Assignees

@blanchco blanchco

@asylves1 asylves1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@YohannParis @mwdchang @dvince2 @blanchco @asylves1