Skip to content
This repository has been archived by the owner on Mar 27, 2022. It is now read-only.

Add global basename support #17

Merged
merged 9 commits into from
Feb 14, 2017
Merged

Add global basename support #17

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
80bd4c1
add global basename option support for FileDriver
stefanotorresi Jan 31, 2017
bb2135c
update example config
stefanotorresi Jan 31, 2017
fc97f51
remove declare statements
stefanotorresi Jan 31, 2017
77c67e2
call assertion statically
stefanotorresi Jan 31, 2017
16ea133
make DriverFactory able to build Simplified* drivers
stefanotorresi Feb 1, 2017
1c2aad7
Revert "call assertion statically"
stefanotorresi Feb 9, 2017
175e8d5
group related if statement
stefanotorresi Feb 9, 2017
da65f82
Revert "group related if statement"
stefanotorresi Feb 9, 2017
6a10096
use array_key_exists instead of isset
stefanotorresi Feb 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/DriverFactoryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,6 @@ public function testItSupportsGlobalBasenameOptionOnFileDrivers()
$factory = new DriverFactory();

$driver = $factory($container->reveal());
$this->assertSame($globalBasename, $driver->getGlobalBasename());
static::assertSame($globalBasename, $driver->getGlobalBasename());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with the rest of the project I wouldn't call assertSame() statically.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't look at the rest tbh, just spotted it was incorrect shrug

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so what's it gonna be then? static or not? 😛

Copy link
Contributor Author

@stefanotorresi stefanotorresi Feb 1, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know what, I'll leave it at that for now, and then make a different PR where we update PHPUnit and standardise assertion invocation all over the test suite. Sounds good to you all?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use local assertions.

}
}