Skip to content
This repository has been archived by the owner on Mar 27, 2022. It is now read-only.

Added support for cache chains with multiple cache providers #19

Merged
merged 4 commits into from
Apr 3, 2017
Merged

Added support for cache chains with multiple cache providers #19

merged 4 commits into from
Apr 3, 2017

Conversation

arjanvdbos
Copy link
Contributor

This change makes it possible to configure cache chains of existing cache providers.

@coveralls
Copy link

Coverage Status

Coverage increased (+6.4%) to 46.113% when pulling 98a0d6a on arjanvdbos:add-cache-chain-support into ab97e2e on DASPRiD:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+6.4%) to 46.113% when pulling 1a81043 on arjanvdbos:add-cache-chain-support into ab97e2e on DASPRiD:master.

Copy link
Collaborator

@asgrim asgrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean enough, don't think there's any BC breaks here. Wonder if it might be useful to add an example usage to the example config?

@coveralls
Copy link

Coverage Status

Coverage increased (+6.4%) to 46.113% when pulling 682bc9d on arjanvdbos:add-cache-chain-support into ab97e2e on DASPRiD:master.

@arjanvdbos
Copy link
Contributor Author

Thanks for your feedback @asgrim, i've added an example to full-config.php. I'm looking forward to any other comments...

@asgrim asgrim self-assigned this Apr 3, 2017
@asgrim asgrim added this to the 1.0.0 milestone Apr 3, 2017
@asgrim asgrim merged commit be47616 into DASPRiD:master Apr 3, 2017
@asgrim
Copy link
Collaborator

asgrim commented Apr 3, 2017

Great - thanks @arjanvdbos!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants