Feature dropdown down #1430
Merged
Feature dropdown down #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjohans
approved these changes
Apr 5, 2024
YousefMohsen
added a commit
that referenced
this pull request
Apr 9, 2024
* in progress - first shot * in progress - deleted som files * setFacets * in progress * in progress .. write a test * usefacet hook * added a test * in progress - small steps * in progress - bugfix + component to style * in progress - facets from enum * in progress - remove consoles - find the query * in progress - working copy * more facets * some styling + changes from review * remove some unused vars * fixed a test + a real error * set facetlimit 50 + slice facetlist * bugfixed + ALL facets * debugging * fixed a bug * added facet tags * formatting * remove unused var * ... (#1397) * Bibdk2021 2032 mobile facets (#1398) * fix it (#1394) * fix it (#1396) * in progress - added modal * in progress - skeleton on facets + useGlobal hook * ... (#1397) * in progress - back to working copy * in progress - added replace for modal * update modal facets + correct modal * in progress - some mobile styling + facettags on mobile * in progress - remove usestate * working facet browser ! * in progress .. small steps :) * facetbutton in own component * some mobile styling * formatting :) * modal page for mobile facets * removed some unused vars * datacheck * cleanup a little * fix a test - we dont need facets as dependency here * skeleton when loading --------- Co-authored-by: kfudbc <kfudbc@users.noreply.github.com> Co-authored-by: mtni <36037828+mtni@users.noreply.github.com> * Bibdk2021 2464 nextjs 14 (#1389) * const + link fix * works with nextjs * nextjs * fixed stuff * legacyBehavior * remove comment * audit * fixed imports * fixed lint error * comment * Bibdk2021 2530 searchhistory (#1399) * filters in search history * remove unused * disable orderconfirmation for periodica (#1402) * disable orderconfirmation for periodica * change from review - false is the way * dbc-node:latest (#1403) * Bibdk2021 2530 searchhistory2 (#1404) * in progress - split historyobject * today, yesterday and older in searchhistory * props in lower case * disable orderconfirmation for periodica (#1402) * disable orderconfirmation for periodica * change from review - false is the way * dbc-node:latest (#1403) * fixed router issue with next14 * ... (#1401) * handle developer fuckups when ordering * Reuse filter page (#1406) * disable orderconfirmation for periodica (#1402) * disable orderconfirmation for periodica * change from review - false is the way * dbc-node:latest (#1403) * ... (#1401) * in progress - bugfixing * handle developer fuckups when ordering * in progress - modal mobil facetpage + various changes on filter.page * and filter page also * update usefacet + implement onselect event --------- Co-authored-by: Yousef <yousefmohsen@outlook.dk> Co-authored-by: mtni <36037828+mtni@users.noreply.github.com> * deleted old test * skeletorn while loading * fixes multi order status on bookmark page (#1407) * fixes multi order status on bookmark page * clean up * console log * clean clean * bookmark key * handleOrderFinished * list of facets * skeleton when loading * added translations * fixed a test * refactor - only allow components in subtitle (#1409) * fixed a test * some styling for desktop * remove unused var * skeleton ! * advanced search tab (#1408) * Bibdk2021 2494 fix alarms (#1410) * fixed some bugs * replaceAll -> replace * replace replaceall with replace * json parse fix * replace replaceall * added japanese and persian languages (#1411) * fixed some bugs (#1413) * fixed some bugs * we still use it * open popover (#1417) * Bibdk2021 2549 (#1418) * prefer resolver over field given by parent * added 'not available for home loan' message for reservation button * rm unused * reset periodica form after ordering (#1421) * reset periodica form after ordering * a little test * a little test * refix RESOURCE bug (#1423) * prioritize access (#1412) * prioritize access * sort access * console log * added if * Bibdk2021 2554 lorem ipsum (#1424) * in progress - no bibdkexclude * excludebranches:false * hide sort if hitcount > 0 (#1419) * Bibdk2021 2364 new user link (#1420) * open popover * new user link * prioritize cporation name (#1425) * added new localization message, on shelf but not loanable (#1422) * added new localization message, on shelf but not loanable * fix test * fix more localization status * decode url before json.parse (#1415) * styling + functional changes from review * remove volume from title (#1427) * filter result (#1426) * Bibdk2021 2393 related worktypes only (#1429) * handle selected worktypes only * handle selected worktypes only * handle selected worktypes only * enable test + new story * added id field for music (#1428) * fixed mobile refresh * some styling - yeah * Feature dropdown down (#1430) * dropdown always down * dropdown direction * comment * test fix (#1433) * test fix * remove only * cy version * Bibdk2021 2270 no tags please (#1432) * do not show tags section if there are no tags * do not show tags section if there are no tags * do not show tags section if there are no tags * do not show tags section if there are no tags * mobile facets css + functional change from review (#1435) * fixed a test - no hitcount for simple search filters * added a little test * no scroll for now * reintroduce smooth scroll - yeah * Bibdk2021 1609 participants (#1434) * show participant in seperate field * show participant in seperate field * final (#1431) * fixed search history * sort refined * lock tab (#1436) * lock tab * prettier * shadow fix (#1437) * shadow fix * use var * sort by score - ff bugfix * one sort to rule --------- Co-authored-by: pjohans <pjohans@gmail.com> Co-authored-by: mtni <36037828+mtni@users.noreply.github.com> Co-authored-by: kfudbc <kfudbc@users.noreply.github.com>
YousefMohsen
added a commit
that referenced
this pull request
Apr 10, 2024
* in progress - first shot * in progress - deleted som files * setFacets * in progress * in progress .. write a test * usefacet hook * added a test * in progress - small steps * in progress - bugfix + component to style * in progress - facets from enum * in progress - remove consoles - find the query * in progress - working copy * more facets * some styling + changes from review * remove some unused vars * fixed a test + a real error * set facetlimit 50 + slice facetlist * bugfixed + ALL facets * debugging * fixed a bug * added facet tags * formatting * remove unused var * ... (#1397) * Bibdk2021 2032 mobile facets (#1398) * fix it (#1394) * fix it (#1396) * in progress - added modal * in progress - skeleton on facets + useGlobal hook * ... (#1397) * in progress - back to working copy * in progress - added replace for modal * update modal facets + correct modal * in progress - some mobile styling + facettags on mobile * in progress - remove usestate * working facet browser ! * in progress .. small steps :) * facetbutton in own component * some mobile styling * formatting :) * modal page for mobile facets * removed some unused vars * datacheck * cleanup a little * fix a test - we dont need facets as dependency here * skeleton when loading --------- Co-authored-by: kfudbc <kfudbc@users.noreply.github.com> Co-authored-by: mtni <36037828+mtni@users.noreply.github.com> * Bibdk2021 2464 nextjs 14 (#1389) * const + link fix * works with nextjs * nextjs * fixed stuff * legacyBehavior * remove comment * audit * fixed imports * fixed lint error * comment * Bibdk2021 2530 searchhistory (#1399) * filters in search history * remove unused * disable orderconfirmation for periodica (#1402) * disable orderconfirmation for periodica * change from review - false is the way * dbc-node:latest (#1403) * Bibdk2021 2530 searchhistory2 (#1404) * in progress - split historyobject * today, yesterday and older in searchhistory * props in lower case * disable orderconfirmation for periodica (#1402) * disable orderconfirmation for periodica * change from review - false is the way * dbc-node:latest (#1403) * fixed router issue with next14 * ... (#1401) * handle developer fuckups when ordering * Reuse filter page (#1406) * disable orderconfirmation for periodica (#1402) * disable orderconfirmation for periodica * change from review - false is the way * dbc-node:latest (#1403) * ... (#1401) * in progress - bugfixing * handle developer fuckups when ordering * in progress - modal mobil facetpage + various changes on filter.page * and filter page also * update usefacet + implement onselect event --------- Co-authored-by: Yousef <yousefmohsen@outlook.dk> Co-authored-by: mtni <36037828+mtni@users.noreply.github.com> * deleted old test * skeletorn while loading * fixes multi order status on bookmark page (#1407) * fixes multi order status on bookmark page * clean up * console log * clean clean * bookmark key * handleOrderFinished * list of facets * skeleton when loading * added translations * fixed a test * refactor - only allow components in subtitle (#1409) * fixed a test * some styling for desktop * remove unused var * skeleton ! * advanced search tab (#1408) * Bibdk2021 2494 fix alarms (#1410) * fixed some bugs * replaceAll -> replace * replace replaceall with replace * json parse fix * replace replaceall * added japanese and persian languages (#1411) * fixed some bugs (#1413) * fixed some bugs * we still use it * added contributors/creators FromDescription * added contributors from description * added contributors from description * open popover (#1417) * Bibdk2021 2549 (#1418) * prefer resolver over field given by parent * added 'not available for home loan' message for reservation button * rm unused * reset periodica form after ordering (#1421) * reset periodica form after ordering * a little test * a little test * refix RESOURCE bug (#1423) * prioritize access (#1412) * prioritize access * sort access * console log * added if * Bibdk2021 2554 lorem ipsum (#1424) * in progress - no bibdkexclude * excludebranches:false * hide sort if hitcount > 0 (#1419) * Bibdk2021 2364 new user link (#1420) * open popover * new user link * prioritize cporation name (#1425) * added new localization message, on shelf but not loanable (#1422) * added new localization message, on shelf but not loanable * fix test * fix more localization status * decode url before json.parse (#1415) * styling + functional changes from review * remove volume from title (#1427) * filter result (#1426) * Bibdk2021 2393 related worktypes only (#1429) * handle selected worktypes only * handle selected worktypes only * handle selected worktypes only * enable test + new story * added id field for music (#1428) * fixed mobile refresh * some styling - yeah * Feature dropdown down (#1430) * dropdown always down * dropdown direction * comment * test fix (#1433) * test fix * remove only * cy version * Bibdk2021 2270 no tags please (#1432) * do not show tags section if there are no tags * do not show tags section if there are no tags * do not show tags section if there are no tags * do not show tags section if there are no tags * mobile facets css + functional change from review (#1435) * fixed a test - no hitcount for simple search filters * added a little test * no scroll for now * reintroduce smooth scroll - yeah * Bibdk2021 1609 participants (#1434) * show participant in seperate field * show participant in seperate field * final (#1431) * fixed search history * sort refined * lock tab (#1436) * lock tab * prettier * shadow fix (#1437) * shadow fix * use var * sort by score - ff bugfix * one sort to rule * Searchhistory checkbox fix (#1440) * comment on sort func * fixed checkboxes * fixed a test * minor css fix * and fixed another merge conflict --------- Co-authored-by: pjohans <pjohans@gmail.com> Co-authored-by: mtni <36037828+mtni@users.noreply.github.com> Co-authored-by: kfudbc <kfudbc@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.