Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add agencies endpoint #152

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

akri-dbcdk
Copy link
Contributor

agencyBranches: [AgencyBranch!]!
}

type AgencyBranch {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

her kunne man nok genbruge dender branch der allerede er

agencies: [Agency!]!
}

type Agency {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

god ide med en agency type - det har vi snakket om flere gange

},
context
) {
const librariesFound = await context.getLoader("library").load({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

så .. du lavet præcis samme forespørgsel som til library ? - og så grupperer du efter agency ? eller forstår jeg det rigtigt ?

Copy link
Member

@pjohans pjohans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

det er rigtigt fint - meget velstruktureret kode med test og det hele .. men dender agencybranch ska ikke være der - der må vi kunne genbruge de branches der allerede er

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants