-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add agencies endpoint #152
base: master
Are you sure you want to change the base?
Conversation
agencyBranches: [AgencyBranch!]! | ||
} | ||
|
||
type AgencyBranch { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
her kunne man nok genbruge dender branch der allerede er
agencies: [Agency!]! | ||
} | ||
|
||
type Agency { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
god ide med en agency type - det har vi snakket om flere gange
}, | ||
context | ||
) { | ||
const librariesFound = await context.getLoader("library").load({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
så .. du lavet præcis samme forespørgsel som til library ? - og så grupperer du efter agency ? eller forstår jeg det rigtigt ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
det er rigtigt fint - meget velstruktureret kode med test og det hele .. men dender agencybranch ska ikke være der - der må vi kunne genbruge de branches der allerede er
https://dbcjira.atlassian.net/browse/BIBDK2021-1726