Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hack To skip Task where HealthCheckResults[0].Alive is False #17

Merged
merged 1 commit into from
Feb 1, 2018
Merged

Hack To skip Task where HealthCheckResults[0].Alive is False #17

merged 1 commit into from
Feb 1, 2018

Conversation

ja7
Copy link
Contributor

@ja7 ja7 commented Jan 31, 2018

Kunne dette være en løsning på vores problem med langsomt startende services

@ja7 ja7 requested review from srhb and adamtulinius January 31, 2018 21:54
@srhb
Copy link
Contributor

srhb commented Feb 1, 2018

Nej, den skelner ikke mellem "task der starter op og har healthcheck som ikke er OK (endnu)" og tasks der ikke har healthcheck.

@srhb
Copy link
Contributor

srhb commented Feb 1, 2018

Efter snak med @ja7 in person: Det er med vilje der ikke skelnes. I så fald er jeg OK med dette PR.

@srhb srhb merged commit 42a2e9f into master Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srhb srhb srhb approved these changes

@adamtulinius adamtulinius Awaiting requested review from adamtulinius

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ja7 @srhb