fix: properly check for basin availability before getting features

DC-analysis · Oct 23, 2023 · 082eede · 082eede
1 parent 1edc60d
commit 082eede
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/CHANGELOG b/CHANGELOG
@@ -1,3 +1,5 @@
+0.54.1
+ - fix: properly check for basin availability before getting features
 0.54.0
  - fix: partial workaround for #238
  - fix: hash alias for HDF5 Datasets in files not in the file system

diff --git a/dclab/rtdc_dataset/core.py b/dclab/rtdc_dataset/core.py
@@ -342,9 +342,9 @@ def _feature_candidates(self):
         feats = list(self._events.keys())
         feats += list(self._usertemp.keys())
         feats += list(AncillaryFeature.feature_names)
-        if self.basins:
-            feats += list(
-                itertools.chain(*[bn.features for bn in self.basins]))
+        for bn in self.basins:
+            if bn.is_available():
+                feats += bn.features
         feats = sorted(set(feats))
         # exclude non-standard features
         featsv = [ff for ff in feats if dfn.feature_exists(ff)]