Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement caching for RTDCBase.__len__ #237

Closed
paulmueller opened this issue Oct 6, 2023 · 1 comment
Closed

Implement caching for RTDCBase.__len__ #237

paulmueller opened this issue Oct 6, 2023 · 1 comment
Labels
good first issue Good for new contributors

Comments

@paulmueller
Copy link
Member

paulmueller commented Oct 6, 2023 •
edited
Loading

  • Don't use functools.lru_cache or the likes for decorating methods in classes, because this will cause a memory leak
  • This must also work for the exotic Hierarchy_RTDC class
@paulmueller paulmueller added the good first issue Good for new contributors label Oct 6, 2023
@paulmueller paulmueller mentioned this issue Oct 6, 2023
Closed
@paulmueller
Copy link
Member Author

Fixed by @maxschloegel in #240

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for new contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@paulmueller