Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly close basin datasets #238

Closed
paulmueller opened this issue Oct 6, 2023 · 1 comment
Closed

Properly close basin datasets #238

paulmueller opened this issue Oct 6, 2023 · 1 comment
Labels
bug

Comments

@paulmueller
Copy link
Member

RTDC_HDF5 has __enter__ and __exit__ specified. But if we have a basin dataset, we might also run into a memory leak:

There should be an __exit__ or close method defined in RTDCBase, so basin datasets can get cleaned up properly.

Related: #226 #214 #237
@paulmueller paulmueller added the bug label Oct 6, 2023
paulmueller added a commit that referenced this issue Oct 22, 2023
@paulmueller
fix: partial workaround for #238
a76b69d
paulmueller added a commit that referenced this issue Dec 29, 2023
@paulmueller
fix: make sure basins are always closed on context exit (#238)
ee39e87
@paulmueller
Copy link
Member Author

ee39e87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@paulmueller