More type hinting for the codebase #265
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PinkShnack
commented
Nov 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #265 +/- ##
==========================================
- Coverage 91.24% 91.23% -0.02%
==========================================
Files 105 105
Lines 7793 7814 +21
==========================================
+ Hits 7111 7129 +18
- Misses 682 685 +3 ☔ View full report in Codecov by Sentry. |
added 8 commits
November 26, 2024 14:59
PinkShnack
commented
Nov 27, 2024
| @@ -242,7 +253,8 @@ def get_viscosity_mc_pbs_herold_2017( | |||
| return eta | |||
|
|
|||
|
|
|||
| def get_viscosity_water_kestin_1978(temperature: float = 23.0): | |||
| def get_viscosity_water_kestin_1978( | |||
| temperature: float = 23.0) -> float | npt.NDArray: | |||
There was a problem hiding this comment.
If the input type is a float here, then the output can only be a float, and not an ndarray.
However, in get_viscosity above the temperature argument can be a float or an ndarray. Is this correct?
|
@paulmueller |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing to solve the issue #198.