Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preselection based on peak-to-peak analysis #15

Open
paulmueller opened this issue Nov 21, 2023 · 0 comments
Open

Preselection based on peak-to-peak analysis #15

paulmueller opened this issue Nov 21, 2023 · 0 comments

Comments

@paulmueller
Copy link
Member

In dcnum <= 0.14.0, preselection was employed to remove input images that presumably contain no events. This was implemented as follows:

if self.preselect:
    ptp = np.ptp(self.data.image_corr[index])
    if ptp < 0.1 * self.ptp_median:
        # do not use this event
        return None

The ptp_median value was computed from the background data.

Preselection was removed in dcnum 0.15.0, because

  • it represents a preprocessing step that has possibly hidden impact on data processing
  • it is not yet represented in any pipeline identifier

Should we want to re-introduce preselection, then we would need to properly at it with its own pipeline identifier. Should the input data contain duplicate frames, this could also be addressed (instead of segmenting a duplicate frame twice).

@paulmueller paulmueller changed the title Preselection Preselection based on peak-to-peak analysis Nov 21, 2023
paulmueller added a commit that referenced this issue Nov 21, 2023
 - BREAKING CHANGE: Remove preselection capabilities, because it is not
   well integrated into the pipeline. For more information, please see
   issue #15.
 - ref: increment DCNUM_PPID_GENERATION to 7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant