ENH: Simplify setup of ShapeVariationAnalyzerWidget #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the explicit setting of ivars and instead uses
the function `slicer.util.childWidgetVariables`.
The updates was done following these steps:
(1) Systematic replace of "self.<widgetName>" with "self.ui.<widgetName>"
script=ShapeVariationAnalyzer/ShapeVariationAnalyzer.py
for widget in $(cat $script | ack "getUI\('" | cut -d"'" -f2); do
sed "s/self\.$widget/self.ui.$widget/" $script -i;
done
(2) Manual removal of lines including "self.getUI" and removal of
implementation of "getUI" function.
(3) Additional replacements in script:
self.spinBox_colorModeParam1
-> self.ui.spinBox_colorModeParam_1
self.spinBox_colorModeParam2
-> self.ui.spinBox_colorModeParam_2
self.checkableComboBox_ChoiceOfGroup
-> self.ui.checkableComboBox_ChoiceOfGroup
self.collapsibleButton_creationCSVFile
-> self.ui.collapsibleButton_creationCSVFile
self.collapsibleButton_previewClassificationGroups
-> self.ui.collapsibleButton_previewClassificationGroups
self.collapsibleGroupBox_previewVTKFiles
-> self.ui.collapsibleGroupBox_previewVTKFiles
(4) Additional replacements in UI file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the explicit setting of ivars and instead uses
the function
slicer.util.childWidgetVariables.The updates was done following these steps:
self.<widgetName>withself.ui.<widgetName>Manual removal of lines including
self.getUIand removal of implementation ofgetUIfunction.Additional replacements in script: