chore: update add vault proposals

[0xpatrickdev]

• generate from agoric-upgrade-18 (f8c45b8a2e) tag, using agoric run packages/builders/scripts/inter-protocol/add-STARS.js

[netlify]

✅ Deploy Preview for cosmos-proposal-builder ready!

Name	Link
🔨 Latest commit	43095c8
🔍 Latest deploy log	https://app.netlify.com/sites/cosmos-proposal-builder/deploys/6790113aa5f7c60008a11d32
😎 Deploy Preview	https://deploy-preview-59--cosmos-proposal-builder.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[0xpatrickdev]

I did not include the permits - are these changing meaningful? Seems weird to produce makeCoreProposalBehavior versus something more descriptive - iiuc this value matters for installations, versus others which are just truthy?

diff --git a/src/config/inter/addVault/add-oracle-permit.json b/src/config/inter/addVault/add-oracle-permit.json
index 3e58642..57ddf78 100644
--- a/src/config/inter/addVault/add-oracle-permit.json
+++ b/src/config/inter/addVault/add-oracle-permit.json
@@ -12,9 +12,8 @@
     "priceAuthorityAdmin": "priceFeed",
     "startGovernedUpgradable": "priceFeed",
     "vatAdminSvc": "makeCoreProposalBehavior",
-    "zoe": "makeCoreProposalBehavior"
+    "zoe": "priceFeed"
   },
-  "installation": {},
   "instance": {
     "produce": "priceFeed"
   },
@@ -27,6 +26,9 @@
     "produce": "priceFeed"
   },
   "evaluateBundleCap": "makeCoreProposalBehavior",
+  "installation": {
+    "produce": "makeCoreProposalBehavior"
+  },
   "modules": {
     "utils": {
       "runModuleBehaviors": "makeCoreProposalBehavior"

git diff src/config/inter/addVault/add-vault-permit.json
diff --git a/src/config/inter/addVault/add-vault-permit.json b/src/config/inter/addVault/add-vault-permit.json
index b316be6..7b7ef78 100644
--- a/src/config/inter/addVault/add-vault-permit.json
+++ b/src/config/inter/addVault/add-vault-permit.json
@@ -20,7 +20,8 @@
     "consume": {
       "mintHolder": true,
       "scaledPriceAuthority": true
-    }
+    },
+    "produce": "makeCoreProposalBehavior"
   },
   "instance": {
     "produce": true,
@@ -37,4 +38,4 @@
       "runModuleBehaviors": "makeCoreProposalBehavior"
     }
   }
-}
\ No newline at end of file
+}

[mhofman]

Please regenerate using this with agoric-sdk u18 and a revert of the 2 commits mentioned in Agoric/agoric-sdk#10868 so that we can re-use the bundles already on chain.

[Chris-Hibbert]

Thanks, 0xPatrick. This is the change we were looking for. LGTM.

[dckc]

I did not include the permits - are these changing meaningful?

yes.

... Seems weird to produce makeCoreProposalBehavior versus something more descriptive - iiuc this value matters for installations, versus others which are just truthy?

The interpretation at runtime only cares that it's truthy. makeCoreProposalBehavior is a clue that this part of the permit is needed by makeCoreProposalBehavior:

https://github.com/Agoric/agoric-sdk/blob/f0ccde6550d7f0d22fd489205cb12a6598faa2c9/packages/deploy-script-support/src/coreProposalBehavior.js#L2

https://github.com/Agoric/agoric-sdk/blob/f0ccde6550d7f0d22fd489205cb12a6598faa2c9/packages/deploy-script-support/src/coreProposalBehavior.js#L21-L34

https://github.com/Agoric/agoric-sdk/blob/f0ccde6550d7f0d22fd489205cb12a6598faa2c9/packages/deploy-script-support/src/writeCoreEvalParts.js#L8-L11

https://github.com/Agoric/agoric-sdk/blob/f0ccde6550d7f0d22fd489205cb12a6598faa2c9/packages/deploy-script-support/src/writeCoreEvalParts.js#L167-L169