Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F18 Standby Altimeter fix+A10 cleanup #138

Merged
merged 2 commits into from
Jan 8, 2023

Conversation

DeadMeatDCS
Copy link

Changed 1000 ft counter and pressure setting 3 (hundreds) to defineFloat type instead of defineFloatWithValueConversion which didn't work.

Changed 1000 ft counter and pressure setting 3 (hundreds) to defineFloat type instead of defineFloatWithValueConversion which doesn't work.
Internal lights descriptions were fixed but the old ones snuck back in so we have double definitions. 
Moved and renamed caution lights as well (it's stuck at 100%, but this is bug in DCS; not DCS-BIOS. signal lights switch is supposed to be able to dim them)
@DeadMeatDCS
Copy link
Author

Also updated A10:
Internal lights descriptions were fixed but the old ones snuck back in so we have double definitions.
Moved and renamed caution lights as well (it's stuck at 100%, but this is bug in DCS; not DCS-BIOS. signal lights switch is supposed to be able to dim them)

@DeadMeatDCS DeadMeatDCS changed the title F18 Standby Altimeter fix F18 Standby Altimeter fix+A10 cleanup Jan 7, 2023
@WarLord211
Copy link
Member

Thanks for the PR.
F-18 is good and goes in base branch. (i will clean some now unneeded code)
A-10 to avoid to much address changings and breaking cockpits. i would stay with the old ones and delete the lines 1290-1294, with no renaming. change less code as possible

@WarLord211 WarLord211 merged commit 13a521c into DCS-Skunkworks:master Jan 8, 2023
@DeadMeatDCS
Copy link
Author

Yeah that's a better idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants