#120 Fix missing information on wind page #236
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #222, which seems to have caused more issues than it fixed. This fixes most of the issues, but at least one remains that I'm not able to resolve at this time. I believe this to be an ED bug and I'm not sure how to work around it.
Background
It looks like
WIND
is the base page.WIND1
andWIND2
are the pages with the wind data. They seem to inherit from the baseWIND
page, as they have the same sort of header information. TheSYS
/SYS1
/SYS2
pages seem to behave similarly in the code, however they hardly inherit anything and don't have conflicting definitions like these do.It seems like what's going on here is that the
WIND
base page has an object calledWINDTemp
. This temperature is displayed in the top right, on line 2. TheWIND1
page, responsible for showing the user-entered winds, also has an object calledWINDTemp
- which shows the temperature of the wind on the first line entered - but curiously, only when there isn't actually any temperature data to show.As soon as data is added to that line, it's stored in
WNDTemp1
and all is well.What this PR does
This PR firstly rolls back the initial changes made in #222 as they were not effective.
Next, this PR stops showing
WINDTemp
on the subpages, and only on the base page. This has the side effect that if the first wind entry does not have a temperature, then***
is shown where the outside air temperature is supposed to be shown in the top right, and nothing is shown for that line. To the best of my knowledge, the outside air temperature isn't exposed anywhere for us to get during this time. This seems like an ED bug.Finally, this PR adds support for parent pages to text displays. This means that
WIND1
is able to show all items onWIND
as well as all of its own items.In pictures:
When no items are present, everything displays correctly
Upon adding an item with no temperature, OAT disappears
Upon adding a temperature, OAT is restored
There are no issues when items other than line 1 have no temperature
However, this issue occurs for line 1 on any page
And again, providing a temperature fixes the issue