Don't export MetadataStart/End with any modules #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MetadataStart and End are explicitly run before and after the main module exports, respectively. This is part of what bios guarantees - that MetadataStart will _always_ come first, and MetadataEnd will _always_ come last. As these exports are explicitly run in Protocol.lua for that reason, we don't want to export them with the standard module export code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MetadataStart and End are explicitly run before and after the main module exports, respectively. This is part of what bios guarantees - that MetadataStart will always come first, and MetadataEnd will always come last.
As these exports are explicitly run in Protocol.lua for that reason, we don't want to export them with the standard module export code.
I actually didn't notice this issue until I saw that the generated AircraftAliases.json changed.