Create JSONHelper.lua #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| --- @func Encodes to JSON and writes to file | ||
| --- @param filename string File name including path | ||
| --- @return any |
There was a problem hiding this comment.
return type should be specified (it's a table, I believe? { [string]: any } maybe?)
| --- @param value any | ||
| --- @param filename string File name including path | ||
| function JSONHelper.encode_to_file(value, filename) | ||
| local JSON = BIOS.json |
There was a problem hiding this comment.
The only place BIOS.json will be used is in this file, right? I'm thinking at the very least we should get rid of BIOS.json and just keep that definition local to this file.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wondering how to isolate it more in regards of JSON.lua.