Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug name to MemoryMapEntry #385

Merged

Conversation

charliefoxtwo
Copy link
Member

This enables value out of range logs to include a control name and module name. This should make it easier to uncover issues when observing out of range logs, especially when those logs may contain multiple modules (CommonData, NS430, MetadataStart, MetadataEnd, and in the future Supercarrier are all exported for most modules in addition to the module itself)

before

Util.lua: value -1.000000 is too small for address 26768 mask 65535
Util.lua: value -1.000000 is too small for address 26780 mask 65535

after

Util.lua: value -1.000000 is too small for Mi-24P:PLT_ALT_SHUTTER (address 26768 mask 65535)
Util.lua: value -1.000000 is too small for Mi-24P:OP_ALT_SHUTTER (address 26780 mask 65535)

This enables value out of range logs to include a control name
jdahlblom
jdahlblom previously approved these changes Oct 9, 2023
Copy link
Contributor

@jdahlblom jdahlblom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, this will help out so much.

@jdahlblom
Copy link
Contributor

Util.lua:
Should it read instead MemoryMapEntry : ?

@charliefoxtwo
Copy link
Member Author

Util.lua: Should it read instead MemoryMapEntry : ?

Probably lol. I just never changed it

@jdahlblom jdahlblom added this pull request to the merge queue Oct 9, 2023
Merged via the queue into DCS-Skunkworks:master with commit 01573b0 Oct 9, 2023
2 checks passed
@charliefoxtwo charliefoxtwo deleted the feature/value-range-debug branch October 9, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants