Remove unused address constants from json files #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, as long as the Addresses.h is identical, and nothing is missing from the json files when viewed in control-reference.html, its a great improvement (I have a vague memory of some things missing in control-reference.html when i generated the identifiers in a different place, so please just confirm all 3 address types are present there and not shown as NULL) |
|
Pulled up the control reference html and opened up a few modules (A10, F16, F18) and did a ctrl+f for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the address generation to (mostly, sans legacy modules) remove address constants from the json files where a matching address does not exist in Addresses.h.
@maciekish if you could take a look it would be much appreciated!