Fix #575 FA/18-C UFC Comm triangle symbol not mapping properly #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+164
to
+176
| local comm_channel_cache = {} | ||
|
|
||
| local function get_comm_channel(channel) | ||
| local display_value = channel == 1 and ufc.UFC_Comm1Display or ufc.UFC_Comm2Display | ||
|
|
||
| return comm_channel_map[display_value] or 0 | ||
| if display_value == "d" then -- receiving(?), comm channel hasn't changed | ||
| return comm_channel_cache[channel] or 0 | ||
| end | ||
|
|
||
| local value = comm_channel_map[display_value] or 0 | ||
| comm_channel_cache[channel] = value | ||
|
|
||
| return value |
There was a problem hiding this comment.
I'm new to Lua, so I may be a bit confused by the syntax here..
Why did you introduce the comm_channel_cache?
There was a problem hiding this comment.
This was added to fix a different control that this symbol breaks, which outputs a numeric value for the channel selected. As this symbol I assume is shown for all channels, we want to make sure we're still reporting that the same integer value is selected as the channel selection hasn't changed.
At least, I assume. I don't know why this control was added or who (if anyone) currently uses it.
|
I tested this and it works great! Turns out the |
michaelosthege
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #575
Unclear if this symbol is caused by receiving transmissions on the radio or something else. Would appreciate additional insight.