Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry on play fail and no connection #198

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Retry on play fail and no connection #198

wants to merge 6 commits into from

Conversation

mattcarter11
Copy link
Contributor

@mattcarter11 mattcarter11 commented Jan 7, 2025 •
edited
Loading

What is it?

  • New feature (user facing)
  • Update to existing feature (user facing)
  • Bugfix (user facing)
  • Translations
  • Codebase improvements or refactors (dev facing)
  • Other

Description of the changes in your PR

  • add logic to handle error when no connection
  • expose flag when player is waiting for connection
  • add logic to resume playing on connection
  • add error message when this happens

Closes #181

Due diligence

  • I read the contribution guidelines.
  • I understand that in the event of merge conflicts, I may be asked to rebase my branch on top of the dev branch, instead of resolving them by merging dev into my own branch

mattcarter11 and others added 5 commits January 15, 2025 18:09
@mattcarter11
player: when playback error because no connection, stop song and show…
7d9bf75 
… loading. When connection back, start playing again
@mattcarter11
retry: if pause stop wait for reconnect
54f5893
@mikooomich @mattcarter11
player: Fixup new on-error logic
95cf014 
* Resurrect runaway diesel engine protection for auto skip
* Re-order if else such to show error message on auto skip
* Separate wait to reconnect on it's own
@mattcarter11
refactor: remove duplicate enum
ee9f4eb
@mattcarter11
on error: simplify logic (remove toggle, just wait for connection or …
ab30239 
…skip upt to two songs on error)
@mattcarter11 mattcarter11 force-pushed the retry-on-play-fail-and-no-connection branch from f4383fb to ab30239 Compare January 15, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skipping songs without touching the next button
2 participants
@mattcarter11 @mikooomich